Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] first pass at a simple interface to extract URIs from a message
Date: Sat, 02 Feb 2008 18:56:40 -0800	[thread overview]
Message-ID: <1202007092-sup-19@south> (raw)
In-Reply-To: <21aa9f0801291923w2df946dbga7832a7345c09a95@mail.gmail.com>

Reformatted excerpts from brabuhr's message of 2008-01-29:
> This adds a new key binding to the thread-view mode (L) to assist with
> loading URIs from the body of the message.  This first pass will pull
> the URIs from the message text and loop through them while asking if
> that URI should be loaded.  Currently, there is no code to actually
> perform the load.

Looks good. I have a slight preference for a "if uris.size == 0" block
that flashes a message and returns, so that the meat of the method
doesn't have to be too indented.

My limited research indicates that there isn't a standard way (like
mailcap) of viewing a URL. So probably a "view-url" hook is the best way
to approach the actual viewing code.

-- 
William <wmorgan-sup at masanjin.net>


  reply	other threads:[~2008-02-03  2:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30  3:23 brabuhr
2008-02-03  2:56 ` William Morgan [this message]
2008-02-09  2:01   ` brabuhr at gmail.com
2008-02-16 20:04 ` William Morgan
2008-02-16 20:06   ` [sup-talk] [PATCH] add URL extraction, listing, and viewing capabilities to ThreadViewMode William Morgan
2008-02-18 23:24   ` [sup-talk] [PATCH] first pass at a simple interface to extract URIs from a message Nicolas Pouillard
2008-02-19  3:12     ` Daniel Wagner
2008-02-19 10:17       ` Nicolas Pouillard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202007092-sup-19@south \
    --to=wmorgan-sup@masanjin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox