From: grant@antiflux.org (Grant Hollingworth)
Subject: [sup-talk] labels for updated messages
Date: Wed, 16 Jan 2008 12:38:22 -0500 [thread overview]
Message-ID: <1200504528-sup-4009@spooky.local> (raw)
When a message is updated, source labels are not applied to it.
PollManager.do_poll:
add_messages_from source do |m, offset, entry|
## always preserve the labels on disk.
m.labels = entry[:label].split(/\s+/).map { |x| x.intern } if entry
This means that when I write to a mailing list, the message never gets a list
label applied, even when the message is updated from a source for that list.
The thread will be missing its label unless someone replies to my message.
The code above could merge in the source labels. It seems to me that it would
be uncommon to remove a label only to have it re-added when the message is
updated. It still bugs me to leave that unaddressed, though. We could keep
track of deleted labels, but that seems like a lot of work for an uncommon
situation.
next reply other threads:[~2008-01-16 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-16 17:38 Grant Hollingworth [this message]
2008-01-19 17:18 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200504528-sup-4009@spooky.local \
--to=grant@antiflux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox