Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] Added quoteline hook. This allows you to specify how the text above the quoted email should look (Normally 'Excerpts froms...')
Date: Mon, 14 Jan 2008 21:20:17 -0800	[thread overview]
Message-ID: <1200374341-sup-8557@south> (raw)
In-Reply-To: <1200313448-sup-3169@tomsk>

Hi Marcus,

Two small comments:

First, can you please use the Official Commit Log Entry Format(tm) as
detailed on the wiki, so that all the git tools that rely on that
function nicely?

Second:

Excerpts from Marcus Williams's message of Mon Jan 14 04:24:27 -0800 2008:
> +    lines = [quoteline] + m.quotable_body_lines.map { |l| "> #{l}" }

Can we instead do quoteline.split("\n"), so that people can return
multi-line things? Not that I endore that practice, but, de gustibus and
all that.

Other than that looks good.

-- 
William <wmorgan-sup at masanjin.net>


  reply	other threads:[~2008-01-15  5:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-14 12:24 Marcus Williams
2008-01-15  5:20 ` William Morgan [this message]
2008-01-15  9:18   ` Marcus Williams
2008-01-15  9:40     ` [sup-talk] [PATCH] Added quoteline hook for reply mode Marcus Williams
2008-01-16  1:31       ` William Morgan
2008-01-16 16:32       ` Grant Hollingworth
2008-01-16 16:39         ` Marcus Williams
2008-01-16 21:09           ` William Morgan
2008-01-17 17:49             ` [sup-talk] [PATCH] renamed "quoteline" hook to "attribution" Grant Hollingworth
2008-01-22  2:49               ` William Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200374341-sup-8557@south \
    --to=wmorgan-sup@masanjin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox