From mboxrd@z Thu Jan  1 00:00:00 1970
From: nicolas.pouillard@gmail.com (Nicolas Pouillard)
Date: Mon, 14 Jan 2008 10:01:58 +0100
Subject: [sup-talk] [PATCH] Avoid re-adding the signature when
	re-editing a draft with edit_signature: true
In-Reply-To: <1200271922-sup-919@south>
References: <1200235575295-git-send-email-nicolas.pouillard@gmail.com>
	<1200271922-sup-919@south>
Message-ID: <1200301275-sup-5169@ausone.local>

Excerpts from William Morgan's message of Mon Jan 14 01:55:28 +0100 2008:
> Hi Nicholas,
Hi,

> Forgive me for being picky. I've just updated HACKING (on master) to
> add:
> 
> +- and/or versus ||/&&. In Ruby, "and" and "or" bind very loosely---even
> +  more loosely than function application. This makes them ideal for
> +  end-of-line short-circuit control in poetry mode. So, use || and &&
> +  for ordinary logical comparisons, and "and" and "or" for end-of-line
> +  flow control. E.g.:
> +    x = a || b or raise "neither is true"
> 
> So can you change this:
> 
> > +    @body += sig_lines if $config[:edit_signature] and not
> > opts.delete(:have_signature)
> 
> To either "&& !" or to "unless".

Done.

> Other than that everything looks good.

Thanks.

-- 
Nicolas Pouillard aka Ertai