From mboxrd@z Thu Jan 1 00:00:00 1970 From: wmorgan-sup@masanjin.net (William Morgan) Date: Sun, 13 Jan 2008 17:06:37 -0800 Subject: [sup-talk] [PATCH] (Double/guarded) keypress to show all threads In-Reply-To: <1200247733-sup-3710@tomsk> References: <1200071751-sup-5552@tomsk> <1200201168-sup-5812@south> <1200247733-sup-3710@tomsk> Message-ID: <1200272179-sup-6412@south> Excerpts from Marcus Williams's message of Sun Jan 13 10:16:12 -0800 2008: > What I'm working on is getting it to stop searching if the user > presses a key (so you get a progress of 'Found ??? threads (press ESC > to stop)' or something, but no luck yet :( Excellent, that would be great. I don't think it will be too hard: in ThreadIndexMode#load_n_threads, in the block that's passed to @ts.load_n_threads, just check to see if a boolean instance variable is true, and break if so (and reset it). That block is called after each thread is loaded, so the ThreadSet will still be in a consistent state. Then add a keypress to set that flag to true, if @load_thread is true. > I guess it doesnt actually have to return the threads a la gmail > (gmail lets you select all threads in search without actually > displaying them but its _fast_). The general slowness of this type of operation in Sup is a real problem, IMO. I think we can go a long way by caching threading information, though of course that's at the expense of disk space. -- William