From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] (Double/guarded) keypress to show all threads
Date: Sun, 13 Jan 2008 17:06:37 -0800 [thread overview]
Message-ID: <1200272179-sup-6412@south> (raw)
In-Reply-To: <1200247733-sup-3710@tomsk>
Excerpts from Marcus Williams's message of Sun Jan 13 10:16:12 -0800 2008:
> What I'm working on is getting it to stop searching if the user
> presses a key (so you get a progress of 'Found ??? threads (press ESC
> to stop)' or something, but no luck yet :(
Excellent, that would be great. I don't think it will be too hard: in
ThreadIndexMode#load_n_threads, in the block that's passed to
@ts.load_n_threads, just check to see if a boolean instance variable is
true, and break if so (and reset it). That block is called after each
thread is loaded, so the ThreadSet will still be in a consistent state.
Then add a keypress to set that flag to true, if @load_thread is true.
> I guess it doesnt actually have to return the threads a la gmail
> (gmail lets you select all threads in search without actually
> displaying them but its _fast_).
The general slowness of this type of operation in Sup is a real
problem, IMO. I think we can go a long way by caching threading
information, though of course that's at the expense of disk space.
--
William <wmorgan-sup at masanjin.net>
next prev parent reply other threads:[~2008-01-14 1:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 17:20 Marcus Williams
2008-01-13 5:30 ` William Morgan
2008-01-13 15:57 ` Nicolas Pouillard
2008-01-13 18:16 ` Marcus Williams
2008-01-14 1:06 ` William Morgan [this message]
2008-01-14 10:54 ` Marcus Williams
2008-01-15 4:49 ` William Morgan
2008-01-15 12:29 ` [sup-talk] [PATCH] Search all threads with option to cancel Marcus Williams
2008-01-16 4:30 ` William Morgan
2008-01-16 10:47 ` Marcus Williams
2008-01-16 21:09 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200272179-sup-6412@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox