From mboxrd@z Thu Jan 1 00:00:00 1970 From: wmorgan-sup@masanjin.net (William Morgan) Date: Sun, 13 Jan 2008 16:55:28 -0800 Subject: [sup-talk] [PATCH] Avoid re-adding the signature when re-editing a draft with edit_signature: true In-Reply-To: <1200235575295-git-send-email-nicolas.pouillard@gmail.com> References: <1200235575295-git-send-email-nicolas.pouillard@gmail.com> Message-ID: <1200271922-sup-919@south> Hi Nicholas, Forgive me for being picky. I've just updated HACKING (on master) to add: +- and/or versus ||/&&. In Ruby, "and" and "or" bind very loosely---even + more loosely than function application. This makes them ideal for + end-of-line short-circuit control in poetry mode. So, use || and && + for ordinary logical comparisons, and "and" and "or" for end-of-line + flow control. E.g.: + x = a || b or raise "neither is true" So can you change this: > + @body += sig_lines if $config[:edit_signature] and not > opts.delete(:have_signature) To either "&& !" or to "unless". Other than that everything looks good. -- William