From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] Avoid re-adding the signature when re-editing a draft with edit_signature: true
Date: Sun, 13 Jan 2008 16:55:28 -0800 [thread overview]
Message-ID: <1200271922-sup-919@south> (raw)
In-Reply-To: <1200235575295-git-send-email-nicolas.pouillard@gmail.com>
Hi Nicholas,
Forgive me for being picky. I've just updated HACKING (on master) to
add:
+- and/or versus ||/&&. In Ruby, "and" and "or" bind very loosely---even
+ more loosely than function application. This makes them ideal for
+ end-of-line short-circuit control in poetry mode. So, use || and &&
+ for ordinary logical comparisons, and "and" and "or" for end-of-line
+ flow control. E.g.:
+ x = a || b or raise "neither is true"
So can you change this:
> + @body += sig_lines if $config[:edit_signature] and not
> opts.delete(:have_signature)
To either "&& !" or to "unless".
Other than that everything looks good.
--
William <wmorgan-sup at masanjin.net>
next prev parent reply other threads:[~2008-01-14 0:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-13 14:46 Nicolas Pouillard
2008-01-14 0:55 ` William Morgan [this message]
2008-01-14 0:56 ` William Morgan
2008-01-14 9:01 ` Nicolas Pouillard
2008-01-14 9:00 Nicolas Pouillard
2008-01-15 5:05 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200271922-sup-919@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox