From mboxrd@z Thu Jan 1 00:00:00 1970 From: wmorgan-sup@masanjin.net (William Morgan) Date: Sat, 12 Jan 2008 18:32:20 -0800 Subject: [sup-talk] [PATCH] Fix for some warnings In-Reply-To: <1200049520-sup-6114@tomsk> References: <1200049520-sup-6114@tomsk> Message-ID: <1200191029-sup-8287@south> Hi Marcus, > returning("sup-faked-" + Digest::MD5.hexdigest(raw_header)) do |id| > - Redwood::log "faking message-id for message from #@from: #{id}" > + fakeid = id > end In this case, we can just assign the result directly to fakeid rather than using the k-combinator (aka "returning"). Also there was a bit of extraneous whitespace introduced at the end of one line in that patch, which became obvious when I did a git diff --color. Can you try using git-format-patch to send the patch? It will create a nice email out of a commit for you, which I can then apply without too much effort. (Or if you're feeling courageous, use git-send-email, which will also do the emailing for you.) I'm going to add a page to the wiki with an overview of git, branching, and submitting patches. -- William