From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] Fix for some warnings
Date: Sat, 12 Jan 2008 18:32:20 -0800 [thread overview]
Message-ID: <1200191029-sup-8287@south> (raw)
In-Reply-To: <1200049520-sup-6114@tomsk>
Hi Marcus,
> returning("sup-faked-" + Digest::MD5.hexdigest(raw_header)) do |id|
> - Redwood::log "faking message-id for message from #@from: #{id}"
> + fakeid = id
> end
In this case, we can just assign the result directly to fakeid rather
than using the k-combinator (aka "returning"). Also there was a bit of
extraneous whitespace introduced at the end of one line in that patch,
which became obvious when I did a git diff --color.
Can you try using git-format-patch to send the patch? It will create a
nice email out of a commit for you, which I can then apply without too
much effort. (Or if you're feeling courageous, use git-send-email, which
will also do the emailing for you.)
I'm going to add a page to the wiki with an overview of git, branching,
and submitting patches.
--
William <wmorgan-sup at masanjin.net>
next prev parent reply other threads:[~2008-01-13 2:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 11:09 Marcus Williams
2008-01-13 2:32 ` William Morgan [this message]
2008-01-13 3:32 ` William Morgan
2008-01-14 2:17 ` William Morgan
2008-01-13 18:19 ` Marcus Williams
2008-01-15 14:02 ` [sup-talk] [PATCH] Fix for some warnings on faked addresses and ids Marcus Williams
2008-01-16 1:32 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200191029-sup-8287@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox