From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] More gmail search goodness
Date: Sat, 22 Dec 2007 16:45:54 -0800 [thread overview]
Message-ID: <1198367430-sup-936@south> (raw)
In-Reply-To: <1196202259-sup-7348@tomsk>
Excerpts from Marcus Williams's message of Tue Nov 27 14:34:02 -0800 2007:
> Simple patch attached. Adds the "during" operator to the date searches
> so you can say during:today or during:november.
Applied as is. Thanks!
> The last two required changing the return value to a list/pair in
> parse_user_string_query and I'm not sure what the best way to do this
> in ruby is. For now its a simple list.
That's the right way.
> Also is there a better way to deal with a nil result other than
> returning [nil,nil]?
You can just return nil.
> I figured you'd never want to search killed threads... and it made the
> patch nastier because of the :skip_killed flag.
Actually, by default, killed threads are always searched. It's only in
inbox-mode that you don't want to see them.
> I'd like to add a has:attachment operator but the ferret index doesnt
> appear to store enough info for this. It would be really nice to be
> able to search for attachments (of certain types as well with
> filename:...) I took a look at extending the index to add a new field
> "filename" that contains a list of filenames attached to a message,
> but this would break everyones index so I'm just requesting it as a
> wishlist item rather than submitting a patch.
You're right, it requires adding an attachment field to the index. I
think that adding a field to the Ferret index doesn't break index
compatibility, so this actually might not be too hard to do. You'll have
to rebuild the index to fill in the attachment status for pre-existing
messages, but the change wouldn't invalidate anyone's index.
--
William <wmorgan-sup at masanjin.net>
next prev parent reply other threads:[~2007-12-23 0:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 22:34 Marcus Williams
2007-12-23 0:45 ` William Morgan [this message]
2008-01-18 16:37 ` vasudeva
2008-01-18 17:18 ` Marcus Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198367430-sup-936@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox