From mboxrd@z Thu Jan 1 00:00:00 1970 From: wmorgan-sup@masanjin.net (William Morgan) Date: Fri, 21 Dec 2007 10:23:58 -0800 Subject: [sup-talk] Contact Manager and fullname aliasing In-Reply-To: <6205b42d0711241038j3f1b75e6s3ad7a2d7f4d5b316@mail.gmail.com> References: <6205b42d0711220057l79ecc2ect6c4a29dc5efff4ef@mail.gmail.com> <1195843961-sup-2106@south> <6205b42d0711241038j3f1b75e6s3ad7a2d7f4d5b316@mail.gmail.com> Message-ID: <1198260936-sup-7657@south> Hi Pierre, Excerpts from Pierre Baillet's message of Sat Nov 24 10:38:49 -0800 2007: > This is my first implementation. Interestingly enough, most of the > code modified is in person.rb because this class already seems to > store the full name of contacts. Sorry for sitting on this for so long. After reviewing the patch I think I lead you down the wrong path by suggesting an array. I've just pushed a changeset based on your patch which accomplishes the same thing (empty contact aliases are allowed, and contact names can be edited) while still maintaining the mapping in two hashtables. In contact-list-mode editing a contact is bound to both 'a' and 'i', but in thread-view-mode it's bound to 'i' only because people fought long and hard for 'a' to act as archive-and-kill-buffer. Contacts whose name is edited but don't have an alias are still stored in contacts.txt, and anything there overrides what's found in the name cache. So there's currently no way to remove someone from there except by editing the file by hand, but there's not much of a reason to remove someone anyways. Check it out and let me know what you think. -- William