From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] Contact Manager and fullname aliasing
Date: Fri, 21 Dec 2007 10:23:58 -0800 [thread overview]
Message-ID: <1198260936-sup-7657@south> (raw)
In-Reply-To: <6205b42d0711241038j3f1b75e6s3ad7a2d7f4d5b316@mail.gmail.com>
Hi Pierre,
Excerpts from Pierre Baillet's message of Sat Nov 24 10:38:49 -0800 2007:
> This is my first implementation. Interestingly enough, most of the
> code modified is in person.rb because this class already seems to
> store the full name of contacts.
Sorry for sitting on this for so long. After reviewing the patch I think
I lead you down the wrong path by suggesting an array. I've just pushed
a changeset based on your patch which accomplishes the same thing (empty
contact aliases are allowed, and contact names can be edited) while
still maintaining the mapping in two hashtables.
In contact-list-mode editing a contact is bound to both 'a' and 'i', but
in thread-view-mode it's bound to 'i' only because people fought long
and hard for 'a' to act as archive-and-kill-buffer.
Contacts whose name is edited but don't have an alias are still stored
in contacts.txt, and anything there overrides what's found in the name
cache. So there's currently no way to remove someone from there except
by editing the file by hand, but there's not much of a reason to remove
someone anyways.
Check it out and let me know what you think.
--
William <wmorgan-sup at masanjin.net>
prev parent reply other threads:[~2007-12-21 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 8:57 Pierre Baillet
2007-11-23 18:56 ` William Morgan
2007-11-24 18:38 ` Pierre Baillet
2007-12-21 18:23 ` William Morgan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198260936-sup-7657@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox