Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] label-list-mode with no unread messages
Date: Sun, 09 Dec 2007 18:51:36 -0800	[thread overview]
Message-ID: <1197254933-sup-7649@south> (raw)
In-Reply-To: <1196103315-sup-3020@spooky.local>

Excerpts from Grant Hollingworth's message of Mon Nov 26 10:57:49 -0800 2007:
> Handling the unread counts in LabelListMode seems dirty, anyway. You'd
> have to watch more than just the :read event, right? If a thread is
> archived from the inbox, for instance, the unread count for 'Inbox'
> should go down.

Yes, probably the ideal solution is to have a CountManager (sigh) which
maintains all these numbers, and listens to all events. Then
LabelListMode would be a consumer of this.

> So I haven't done any of that... but I found a related problem: the
> inbox doesn't update if you unarchive a thread elsewhere. I made a
> na?ve patch that works in some cases.

I've just committed a fairly large changeset that improves the update
relaying thing. It should fix most problems, including this one. I think
the one thing it doesn't quite get is the case where you remove a label
from a thread that's displayed in a different label-search-results-mode
buffer. Or something like that.

-- 
William <wmorgan-sup at masanjin.net>


      reply	other threads:[~2007-12-10  2:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21 19:53 Grant Hollingworth
2007-11-24 20:47 ` William Morgan
2007-11-26 18:57   ` Grant Hollingworth
2007-12-10  2:51     ` William Morgan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1197254933-sup-7649@south \
    --to=wmorgan-sup@masanjin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox