From mboxrd@z Thu Jan 1 00:00:00 1970 From: wmorgan-sup@masanjin.net (William Morgan) Date: Wed, 28 Nov 2007 09:21:59 -0800 Subject: [sup-talk] [PATCH] mode.focus not called when buffer killed In-Reply-To: <1196201559-sup-3731@spooky.local> References: <1196201559-sup-3731@spooky.local> Message-ID: <1196270440-sup-7754@south> Excerpts from Grant Hollingworth's message of Tue Nov 27 14:18:42 -0800 2007: > r708 changed buffer.rb to set @focus_buf in kill_buffer. The problem > with that is that focus_on (called through raise_to_front) sees that > @focus_buf is set and returns without doing anything... so mode.focus > is never called. Since focus_on will set @focus_buf, I changed > kill_buffer back and moved the focus_on call in raise_to_front out of > the conditional. I think that should still work as expected. Applied, thanks. > If I added some tests, would you use them? Some assertions would > really help with cases like this. Sure! -- William