From: grant@antiflux.org (Grant Hollingworth)
Subject: [sup-talk] [PATCH] mode.focus not called when buffer killed
Date: Tue, 27 Nov 2007 17:18:42 -0500 [thread overview]
Message-ID: <1196201559-sup-3731@spooky.local> (raw)
r708 changed buffer.rb to set @focus_buf in kill_buffer. The problem with that is that focus_on (called through raise_to_front) sees that @focus_buf is set and returns without doing anything... so mode.focus is never called. Since focus_on will set @focus_buf, I changed kill_buffer back and moved the focus_on call in raise_to_front out of the conditional. I think that should still work as expected.
If I added some tests, would you use them? Some assertions would really help with cases like this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sup-kill-buffer-focus.diff
Type: application/octet-stream
Size: 678 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20071127/f9132051/attachment.obj
next reply other threads:[~2007-11-27 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 22:18 Grant Hollingworth [this message]
2007-11-28 17:21 ` William Morgan
2007-11-29 15:50 ` Grant Hollingworth
2007-11-29 18:18 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196201559-sup-3731@spooky.local \
--to=grant@antiflux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox