From: grant@antiflux.org (Grant Hollingworth)
Subject: [sup-talk] [PATCH] label-list-mode with no unread messages
Date: Mon, 26 Nov 2007 13:57:49 -0500 [thread overview]
Message-ID: <1196103315-sup-3020@spooky.local> (raw)
In-Reply-To: <1195936974-sup-3449@south>
Excerpts from William Morgan's message of Sat Nov 24 15:47:34 -0500 2007:
> Shouldn't be too hard to do this if you use catch the appropriate
> events from UpdateManager.
I hadn't looked at the UpdateManager before... that's pretty cool.
The problem is that the text in label-list-mode is created by LabelListMode#regen_text. It would be awkward to fiddle with @text outside of there. Since regen_text gets its numbers from Index.num_results_for, the other buffer has to sync to the index before the label list will know about it. So it seems to be just as effective to add 'def focus; reload; end' to LabelListMode.
Handling the unread counts in LabelListMode seems dirty, anyway. You'd have to watch more than just the :read event, right? If a thread is archived from the inbox, for instance, the unread count for 'Inbox' should go down.
So I haven't done any of that... but I found a related problem: the inbox doesn't update if you unarchive a thread elsewhere. I made a na?ve patch that works in some cases.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sup-inbox-unarchived.diff
Type: application/octet-stream
Size: 988 bytes
Desc: not available
Url : http://rubyforge.org/pipermail/sup-talk/attachments/20071126/5ad3bba1/attachment.obj
next prev parent reply other threads:[~2007-11-26 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 19:53 Grant Hollingworth
2007-11-24 20:47 ` William Morgan
2007-11-26 18:57 ` Grant Hollingworth [this message]
2007-12-10 2:51 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196103315-sup-3020@spooky.local \
--to=grant@antiflux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox