* [sup-talk] bugfix to message-chunks.rb
@ 2007-11-14 8:17 Brendan O'Connor
2007-11-14 15:53 ` William Morgan
0 siblings, 1 reply; 2+ messages in thread
From: Brendan O'Connor @ 2007-11-14 8:17 UTC (permalink / raw)
I was getting some crashes and tracked it down to this line. This patch makes
the crash go away, so I think it's a bugfix (local variable masking the
accessor?) but am not sure.
Index: lib/sup/message-chunks.rb
===================================================================
--- lib/sup/message-chunks.rb (revision 698)
+++ lib/sup/message-chunks.rb (working copy)
@@ -111,7 +111,7 @@
@lines = lines.map { |l| l.chomp.wrap WRAP_LEN }.flatten # wrap
## trim off all empty lines except one
- lines.pop while lines.last =~ /^\s*$/
+ @lines.pop while @lines.last =~ /^\s*$/
end
def inlineable?; true end
^ permalink raw reply [flat|nested] 2+ messages in thread
* [sup-talk] bugfix to message-chunks.rb
2007-11-14 8:17 [sup-talk] bugfix to message-chunks.rb Brendan O'Connor
@ 2007-11-14 15:53 ` William Morgan
0 siblings, 0 replies; 2+ messages in thread
From: William Morgan @ 2007-11-14 15:53 UTC (permalink / raw)
Excerpts from Brendan O'Connor's message of Wed Nov 14 00:17:28 -0800 2007:
> I was getting some crashes and tracked it down to this line. This
> patch makes the crash go away, so I think it's a bugfix (local
> variable masking the accessor?) but am not sure.
I believe you're right. Applied. Thanks!
--
William <wmorgan-sup at masanjin.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-14 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-14 8:17 [sup-talk] bugfix to message-chunks.rb Brendan O'Connor
2007-11-14 15:53 ` William Morgan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox