From: brenocon@gmail.com (Brendan O'Connor)
Subject: [sup-talk] bugfix to message-chunks.rb
Date: Wed, 14 Nov 2007 08:17:28 +0000 [thread overview]
Message-ID: <1195028091-sup-5871@aa0-000-6.u.powerset.com> (raw)
I was getting some crashes and tracked it down to this line. This patch makes
the crash go away, so I think it's a bugfix (local variable masking the
accessor?) but am not sure.
Index: lib/sup/message-chunks.rb
===================================================================
--- lib/sup/message-chunks.rb (revision 698)
+++ lib/sup/message-chunks.rb (working copy)
@@ -111,7 +111,7 @@
@lines = lines.map { |l| l.chomp.wrap WRAP_LEN }.flatten # wrap
## trim off all empty lines except one
- lines.pop while lines.last =~ /^\s*$/
+ @lines.pop while @lines.last =~ /^\s*$/
end
def inlineable?; true end
next reply other threads:[~2007-11-14 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 8:17 Brendan O'Connor [this message]
2007-11-14 15:53 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195028091-sup-5871@aa0-000-6.u.powerset.com \
--to=brenocon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox