From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [BUG] Killed thread and unread count
Date: Sun, 11 Nov 2007 15:57:55 -0800 [thread overview]
Message-ID: <1194824455-sup-3508@south> (raw)
In-Reply-To: <6205b42d0711080222i119831cdl64edf4a3291a3078@mail.gmail.com>
Hi Pierre,
Excerpts from Pierre Baillet's message of Thu Nov 08 02:22:29 -0800 2007:
> When an unread thread is killed, it is still marked as belonging to
> +inbox and hence is accounted as unread by sup in the "Label list".
> However, when displaying the +inbox labelled emails, this thread does
> not appear. I think this behaviour may confuse the user. Shouldn't
> killed threads be marked as read ?
Excellent question. This is actually a symptom of a larger problem,
which is that threading information is never explicitly stored in the
Sup index, and that being killed is a thread-level, not a message-level,
feature. (A killed thread is a thread in which at least one message has
the label :killed.)
So even if you marked a thread as unread before you killed it, the next
time a message in that thread was received, it would count as a new
message in the inbox, even though it never showed up.
In order for unread messages in killed threads to not count as unread
messages, Sup would have to maintain a list of all message-ids in all
killed threads, and check new messages against that list before
incrementing the unread message count. Not impossible, but substantially
harder than just marking killed messages as unread. I've added it to the
TODO.
--
William <wmorgan-sup at masanjin.net>
prev parent reply other threads:[~2007-11-11 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 10:22 Pierre Baillet
2007-11-11 23:57 ` William Morgan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194824455-sup-3508@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox