From mboxrd@z Thu Jan 1 00:00:00 1970 From: wmorgan-sup@masanjin.net (William Morgan) Date: Wed, 07 Nov 2007 09:41:36 -0800 Subject: [sup-talk] [PATCH] Fix for before-add-message hook In-Reply-To: <1194456839-sup-763@south> References: <1194344471-sup-8807@tomsk> <1194400555-sup-7015@south> <1194451347-sup-1828@tomsk> <1194452873-sup-8208@tomsk> <1194456839-sup-763@south> Message-ID: <1194457060-sup-5193@south> Excerpts from William Morgan's message of Wed Nov 07 09:35:11 -0800 2007: > Good catch. Fixed in SVN. (Still refusing to use "and" though > :) ) To be clear, idiomatic Ruby is to use and/or for short-cut exit checks like "or return nil", and use && and || for all "normal" boolean comparisons. I'm not just trying to be a jerk! But I did blindly make that change your patch without thinking about what I was doing, so thank you for catching that. -- William