From mboxrd@z Thu Jan  1 00:00:00 1970
From: itaylor@uark.edu (Ian Taylor)
Date: Tue, 06 Nov 2007 17:57:25 -0500
Subject: [sup-talk] new in svn: in-buffer search
In-Reply-To: <1194388505-sup-2866@south>
References: <1194388505-sup-2866@south>
Message-ID: <1194389659-sup-2148@silver>

Excerpts from William Morgan's message of Tue Nov 06 17:41:37 -0500 2007:
> Thanks to Eyal Oren, who took a first crack at a patch and got me
> excited, SVN head now has in-buffer search.
> 
> First, note that I've remapped the index search from '/' to '\'. Hah!
> 
> '/' now does an in-buffer search, highlights the results, and jumps to
> the first one. 'n' jumps to the next result; ^G or any other key cancels
> the current search.
> 
> Also note that the search is restricted to exactly what you see on the
> screen. Collapsed messages in thread-view-mode, etc must be uncollapsed
> in order to be in-buffer search candidates. Maybe there will be fancier
> behavior in the future.
> 
> Future plans: regex search (very easy to do now), and use the
> highlighting code to make search-results-mode nicer.
> 

Not sure if this was introduced as a result of this patch, but '?' in
the first view seems to crash sup with this error:

The problem was: 'unknown key name "ctrl_g"' (error type ArgumentError)
A backtrace follows:
/var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:54:in `keysym_to_string': unknown key name "ctrl_g" (ArgumentError)
        from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:80:in `help_text'
        from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:80:in `map'
        from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:80:in `help_text'
        from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:77:in `map'
        from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:77:in `help_text'
        from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/modes/help-mode.rb:13:in `initialize'
        from /var/lib/gems/1.8/gems/sup-0.2/bin/sup:217:in `new'
        from /var/lib/gems/1.8/gems/sup-0.2/bin/sup:217
        from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/buffer.rb:262:in `spawn_unless_exists'
        from /var/lib/gems/1.8/gems/sup-0.2/bin/sup:217
        from /var/lib/gems/1.8/bin/sup:16:in `load'
        from /var/lib/gems/1.8/bin/sup:16

My guess is that the following changes need to be made in keymap.rb

     when :end: "<end>"
     when :enter, :return: "<enter>"
     when :ctrl_l: "ctrl-l"
-    when :ctrl_l: "ctrl-g"
+    when :ctrl_g: "ctrl-g"
     when :tab: "tab"
     when " ": "<space>"
     else

-- 
Ian Taylor