From: itaylor@uark.edu (Ian Taylor)
Subject: [sup-talk] new in svn: in-buffer search
Date: Tue, 06 Nov 2007 17:57:25 -0500 [thread overview]
Message-ID: <1194389659-sup-2148@silver> (raw)
In-Reply-To: <1194388505-sup-2866@south>
Excerpts from William Morgan's message of Tue Nov 06 17:41:37 -0500 2007:
> Thanks to Eyal Oren, who took a first crack at a patch and got me
> excited, SVN head now has in-buffer search.
>
> First, note that I've remapped the index search from '/' to '\'. Hah!
>
> '/' now does an in-buffer search, highlights the results, and jumps to
> the first one. 'n' jumps to the next result; ^G or any other key cancels
> the current search.
>
> Also note that the search is restricted to exactly what you see on the
> screen. Collapsed messages in thread-view-mode, etc must be uncollapsed
> in order to be in-buffer search candidates. Maybe there will be fancier
> behavior in the future.
>
> Future plans: regex search (very easy to do now), and use the
> highlighting code to make search-results-mode nicer.
>
Not sure if this was introduced as a result of this patch, but '?' in
the first view seems to crash sup with this error:
The problem was: 'unknown key name "ctrl_g"' (error type ArgumentError)
A backtrace follows:
/var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:54:in `keysym_to_string': unknown key name "ctrl_g" (ArgumentError)
from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:80:in `help_text'
from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:80:in `map'
from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:80:in `help_text'
from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:77:in `map'
from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/keymap.rb:77:in `help_text'
from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/modes/help-mode.rb:13:in `initialize'
from /var/lib/gems/1.8/gems/sup-0.2/bin/sup:217:in `new'
from /var/lib/gems/1.8/gems/sup-0.2/bin/sup:217
from /var/lib/gems/1.8/gems/sup-0.2/lib/sup/buffer.rb:262:in `spawn_unless_exists'
from /var/lib/gems/1.8/gems/sup-0.2/bin/sup:217
from /var/lib/gems/1.8/bin/sup:16:in `load'
from /var/lib/gems/1.8/bin/sup:16
My guess is that the following changes need to be made in keymap.rb
when :end: "<end>"
when :enter, :return: "<enter>"
when :ctrl_l: "ctrl-l"
- when :ctrl_l: "ctrl-g"
+ when :ctrl_g: "ctrl-g"
when :tab: "tab"
when " ": "<space>"
else
--
Ian Taylor
next prev parent reply other threads:[~2007-11-06 22:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 22:41 William Morgan
2007-11-06 22:57 ` Ian Taylor [this message]
2007-11-07 0:18 ` William Morgan
2007-11-07 8:53 ` Marcus Williams
2007-11-07 9:21 ` Eyal Oren
2007-11-07 9:43 ` Marcus Williams
2007-11-07 9:53 ` Marcus Williams
2007-11-12 0:13 ` William Morgan
2007-11-07 14:25 ` vasudeva
2007-11-07 20:41 ` William Morgan
2007-11-07 21:05 ` Marcus Williams
2007-11-12 0:11 ` William Morgan
2007-11-07 21:56 ` Colin Bell
2007-11-12 0:02 ` William Morgan
2007-11-12 0:33 ` Christopher Warrington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194389659-sup-2148@silver \
--to=itaylor@uark.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox