Archive of RubyForge sup-talk mailing list
 help / color / mirror / Atom feed
From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] [PATCH] More IMAP/Maildir functionality
Date: Sun, 04 Nov 2007 19:15:51 -0800	[thread overview]
Message-ID: <1194232297-sup-5089@south> (raw)
In-Reply-To: <1194005479-sup-2005@tomsk>

Hi Marcus,

Excerpts from Marcus Williams's message of Fri Nov 02 05:18:19 -0700 2007:
> This patch cleans up my last IMAP patch, and adds the
> each_raw_message_line method to both Maildir and IMAP so that you dont
> get an exception when you try to save a message to a file with an IMAP
> or maildir source.

This all looks great, except for the source_marked_read stuff, which is
only there as a nasty hack to avoid scanning mbox files twice (because
you can't tell if an mbox message is read or not until you go through
all the headers).

For non-mbox read/unread, it should be sufficient to simply set the flags
as you do in IMAP#raw_header.

If you get a chance, can you resubmit without that? I may have a chance
to clean it up in the next few days if not.

-- 
William <wmorgan-sup at masanjin.net>


  reply	other threads:[~2007-11-05  3:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02 12:18 Marcus Williams
2007-11-05  3:15 ` William Morgan [this message]
2007-11-05  9:54   ` Marcus Williams
2007-11-05 15:44     ` William Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1194232297-sup-5089@south \
    --to=wmorgan-sup@masanjin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox