From: wmorgan-sup@masanjin.net (William Morgan)
Subject: [sup-talk] tiny fix for sup-faked message id's crashing sup-sync
Date: Fri, 02 Nov 2007 08:17:58 -0700 [thread overview]
Message-ID: <1194016481-sup-2712@south> (raw)
In-Reply-To: <472AF56C.5070807@quintic.co.uk>
Excerpts from Marcus Williams's message of Fri Nov 02 03:01:16 -0700 2007:
> ... you may want to remove the @id from the log message - wont this
> always be nil at this point (as it gets assigned by this block)?
Good point. A chance to use my k combinator! Check this out:
--- lib/sup/message.rb (revision 658)
+++ lib/sup/message.rb (working copy)
@@ -62,8 +62,9 @@
if header["message-id"]
sanitize_message_id header["message-id"]
else
- Redwood::log "faking message-id for message from #@from: #@id"
- "sup-faked-" + Digest::MD5.hexdigest(raw_header)
+ returning("sup-faked-" + Digest::MD5.hexdigest(raw_header)) do |id|
+ Redwood::log "faking message-id for message from #@from: #{id}"
+ end
end
date = header["date"]
God I love this language.
--
William <wmorgan-sup at masanjin.net>
prev parent reply other threads:[~2007-11-02 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 1:55 Brendan O'Connor
2007-11-02 2:35 ` William Morgan
[not found] ` <321bb12900151bd3@IMSS-WIN>
2007-11-02 10:01 ` Marcus Williams
2007-11-02 15:17 ` William Morgan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194016481-sup-2712@south \
--to=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox