* [sup-talk] Seen flag treated incorrectly on IMAP mail
@ 2007-10-31 2:12 Colin Bell
0 siblings, 0 replies; 3+ messages in thread
From: Colin Bell @ 2007-10-31 2:12 UTC (permalink / raw)
Hi,
When I connect Sup to a Dovecot imap server all mail that is flagged as new on the server is treated as read by Sup. Sup also sees all old mail as new.
I think its caused by this code in each(...) in imap.rb
labels = { :Seen => :unread,
:Flagged => :starred,
:Deleted => :deleted
}.inject(@labels) do |cur, (imap, sup)|
cur + (state[:flags].include?(imap) ? [sup] : [])
This seems (to my non-existent Ruby skills) to be equating the IMAP
Seen flag to be the same as the Sup Unread flag, instead of Seen as
being Not Unread.
This is running the latest code from Subversion head.
--
Col
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <2d4a3f900012fe89@IMSS-WIN>]
* [sup-talk] Seen flag treated incorrectly on IMAP mail
[not found] <2d4a3f900012fe89@IMSS-WIN>
@ 2007-11-01 9:10 ` Marcus Williams
2007-11-01 22:09 ` Colin Bell
0 siblings, 1 reply; 3+ messages in thread
From: Marcus Williams @ 2007-11-01 9:10 UTC (permalink / raw)
On 31/10/2007 Colin Bell wrote:
> I think its caused by this code in each(...) in imap.rb
>
> labels = { :Seen => :unread,
> :Flagged => :starred,
> :Deleted => :deleted
> }.inject(@labels) do |cur, (imap, sup)|
> cur + (state[:flags].include?(imap) ? [sup] : [])
>
> This seems (to my non-existent Ruby skills) to be equating the IMAP
> Seen flag to be the same as the Sup Unread flag, instead of Seen as
> being Not Unread.
Yep, I submitted a patch earlier last month (search for imap patch) to
fix this although what it did was use the /Recent flag to check for
unread messages. This works as long as you dont use the IMAP source in
any other client before sup checks for new messages.
In reality what it should be checking for is the lack of the /Seen flag.
That requires a patch to the sources generally so they can work out if
they've been read or not (included in my patch). I've also got some
further tweaks to the patch locally that I'll submit once I've tested
them a bit more.
Marcus
^ permalink raw reply [flat|nested] 3+ messages in thread* [sup-talk] Seen flag treated incorrectly on IMAP mail
2007-11-01 9:10 ` Marcus Williams
@ 2007-11-01 22:09 ` Colin Bell
0 siblings, 0 replies; 3+ messages in thread
From: Colin Bell @ 2007-11-01 22:09 UTC (permalink / raw)
Excerpts from Marcus Williams's message of Thu Nov 01 20:10:26 +1100 2007:
>
> Yep, I submitted a patch earlier last month (search for imap patch) to
> fix this although what it did was use the /Recent flag to check for
> unread messages. This works as long as you dont use the IMAP source in
> any other client before sup checks for new messages.
Got it. Thanks for the patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-01 22:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-31 2:12 [sup-talk] Seen flag treated incorrectly on IMAP mail Colin Bell
[not found] <2d4a3f900012fe89@IMSS-WIN>
2007-11-01 9:10 ` Marcus Williams
2007-11-01 22:09 ` Colin Bell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox