From mboxrd@z Thu Jan 1 00:00:00 1970 From: wmorgan-sup@masanjin.net (William Morgan) Date: Thu, 13 Sep 2007 20:42:15 -0700 Subject: [sup-talk] More maildir In-Reply-To: <20070913101519.GA22606@die.therning.org> References: <20070913101519.GA22606@die.therning.org> Message-ID: <1189740804-sup-800@south> Excerpts from Magnus Therning's message of Thu Sep 13 03:15:19 -0700 2007: > I've attached a patch that adds methods that'll make it easier for sup > to play nice with other MUAs when using maildir for storage. Applied! I merged in the several patches you sent into one revision. "svn diff -r572:573" should give it to you. I no longer use Maildir so it's up to you to test it. :) > - What's my Ruby like? (I hadn't even looked at Ruby just 2 weeks > ago so please tell me if I'm doing strange things.) It's great. I made one or two minor tweaks but that's it. (For example, x = y || 3 instead of x = y ? y : 3). > - The methods names are maildir-centric, any suggestions for better > ones? Seems fine to me. The only thing that's going to be globally called is some kind of delete method. > - The maildir state (the flags) are related to some sup labels > ('trashed' is 'deleted' and '!seen' is 'unread'). Is it important to > keep them in sync? (My thinking is no, at least not automatically. > The maildir state could be used when finding new mail during sync to > set the initial labels. It would also be nice if state/labels on > known messages would sync--I think "read in either => read" and > "trashed in either => trashed" is good enough.) This is basically right. Sup interacts with sources in two ways: getting a new message, and during sup-sync-back, and in both places should synchronize read/unread and deleted/undeleted flags. (Actually sup-sync-back doesn't even do read/unread for mbox yet.) Other flags are left alone, except we kindly allow you to delete spam messages as well. -- William