Re: [sup-devel] check keys before sending

From: Gaute Hope <eg@gaute.vetsj.com>
To: Sup developer discussion <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] check keys before sending
Date: Sat, 10 May 2014 18:54:58 +0200	[thread overview]
Message-ID: <CABKe4Msvczo6zDWpBCT9OZspuNObDpVdeTZ0qSDrR4Zv9djDXQ@mail.gmail.com> (raw)
In-Reply-To: <1399708417-sup-4178@ultralap.site>

[-- Attachment #1: Type: text/plain, Size: 1719 bytes --]

I think this can be included if you test and verify the patch. Definetely
very useful.

On Sat, May 10, 2014 at 10:23 AM, Troy Sankey <sankeytms@gmail.com> wrote:

> Hi sup developers,
>
> Recently I sent an encrypted message to a group of recipients, thinking
> that all their keys were still valid.  However, one of them had an
> expired key, so the message was not encrypted to that recipient and he
> could not read it.
>
> I want sup to prompt the user about potentially invalid keys before
> sending a message.  I think the code will look something like this:
>
>
> diff --git a/lib/sup/crypto.rb b/lib/sup/crypto.rb
> index fd8f824..88ae3cc 100644
> --- a/lib/sup/crypto.rb
> +++ b/lib/sup/crypto.rb
> @@ -167,6 +167,14 @@ EOS
>                                 {:operation => "encrypt", :options =>
> gpg_opts}) || gpg_opts
>      recipients = to + [from]
>      recipients = HookManager.run("gpg-expand-keys", { :recipients =>
> recipients }) || recipients
> +
> +    # make sure all recipients can be encrypted-to
> +    recipients.each do |recipient|
> +      if GPGME::Key.find(:public, recipient).length == 0 and
> !BufferManager.ask_yes_or_no("Could not encrypt to #{recipient}. Really
> send?")
> +        raise Error, "Send message cancelled."
> +      end
> +    end
> +
>      begin
>        if GPGME.respond_to?('encrypt')
>          cipher = GPGME.encrypt(recipients, format_payload(payload),
> gpg_opts)
>
>
> I have not tested this patch, so if it looks wrong then it probably is!
> Does anybody have any thoughts on this feature?
>
> Troy
>
> _______________________________________________
> Sup-devel mailing list
> Sup-devel@rubyforge.org
> http://rubyforge.org/mailman/listinfo/sup-devel
>
>

[-- Attachment #2: Type: text/html, Size: 2430 bytes --]