From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.224.47.65 with SMTP id m1cs18549qaf; Tue, 16 Nov 2010 15:23:18 -0800 (PST) Received: by 10.142.231.6 with SMTP id d6mr6546420wfh.346.1289949796570; Tue, 16 Nov 2010 15:23:16 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id g17si4727298ibb.41.2010.11.16.15.23.15; Tue, 16 Nov 2010 15:23:15 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org; dkim=neutral (body hash did not verify) header.i=@gmail.com Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 322CD18583CD; Tue, 16 Nov 2010 18:23:14 -0500 (EST) Received: from mail-qw0-f50.google.com (mail-qw0-f50.google.com [209.85.216.50]) by rubyforge.org (Postfix) with ESMTP id 507FC1858361 for ; Tue, 16 Nov 2010 18:05:51 -0500 (EST) Received: by qwi4 with SMTP id 4so160695qwi.23 for ; Tue, 16 Nov 2010 15:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=rLXUjHdejsgqvt1DvO9bGaKNa3ZaE2DIzYDK7Svq+cI=; b=rhRqAQMU8aEXagWFC3XABe4k1HK4+MEYPEO3d76zydR3IscFye7gVeZyIsx+hra3Mt f4kDRcfRuvgxqw0xph6gRDTUaW2cGUAvgjBNYC9v0pGhlQOMQd9gaBO1Fvs+9nIb2eKO Hm6V8QgKrQlmbnIekvuVJ1P4YKWroNGiudZZ8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=PWphePEUfGfZL7+Uwud4H78NV5hjRjfx92ScRsLj1X3iVXYZBlYXdTcgUX3ZuUUnh/ +KUgKgk4ulp0xq/58fIkoavSYC6usyo1vmRDDxOPXT8DksOCYLQbnZ248zziVkGppR/+ 9LU+brMbvsSGTNdfo2HX459bnYg1H62FO+ZLo= MIME-Version: 1.0 Received: by 10.229.224.79 with SMTP id in15mr6801725qcb.219.1289948751032; Tue, 16 Nov 2010 15:05:51 -0800 (PST) Received: by 10.229.219.68 with HTTP; Tue, 16 Nov 2010 15:05:50 -0800 (PST) In-Reply-To: <1289932061-sup-96@meteor.durcheinandertal.local> References: <1289466286-sup-7540@meteor.durcheinandertal.local> <1289907535-sup-3989@meteor.durcheinandertal.local> <1289932061-sup-96@meteor.durcheinandertal.local> Date: Tue, 16 Nov 2010 23:05:50 +0000 Message-ID: From: Hamish D To: Sup developer discussion Content-Type: multipart/mixed; boundary=0016363b8edc15709a04953399c7 Subject: Re: [sup-devel] [PATCH] Converted crypto to use the gpgme gem X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org --0016363b8edc15709a04953399c7 Content-Type: text/plain; charset=UTF-8 > This does not work for me when running the foobacca/gpgme tree (commit > 7b9a1eeeaaa25931963e2de49410d7cb0c7e6772). The CryptoNotice is empty. Oops. I had one too many flatten! calls and was using the output_lines.flatten! as a return value. However flatten! returns nil if there is no flattening to be done. I've now fixed this in the github tree. Please try it out and let me know how it works for you. >> I am also working on having extra information generated when the key >> is not trusted, but this is not done yet. And I am also working on a >> hook where you can generate as much information as you want from the >> signature for the CryptoNotice. Hopefully be ready to submit before >> the weekend. > > This sounds nice. Thanks for your work! And thank you for your testing and patience :) The github version also has the sig-output hook set up. From the hook text: START Runs when the signature output is being generated, allowing you to add extra information to your signatures if you want. Variables: signature: the signature object (class is GPGME::Signature) from_key: the key that generated the signature (class is GPGME::Key) Return value: an array of lines of output END I've attached a sample hook file if you want to have a play with it. I'll document this all on the wiki if it gets accepted. I'll give you a few days to find some more problems, but if you fail to find any then I'll package this up as a single patch and resubmit it all. Hamish --0016363b8edc15709a04953399c7 Content-Type: application/x-ruby; name="sig-output.rb" Content-Disposition: attachment; filename="sig-output.rb" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ggle3u190 IyBob29rIHRvIHNob3cgZXh0cmEgc3R1ZmYgZnJvbSBzaWduYXR1cmUKIwojIHNpZ25hdHVyZTog dGhlIGtleSBzdHVmZiBpcyBzdGF0dXMsIHN1bW1hcnksIHZhbGlkaXR5IGFuZCB2YWxpZGl0eV9y ZWFzb24KIwojIHN0YXR1cyAtIHVzZWQgYnkgc3VwIGZvciBkZWZhdWx0IG91dHB1dAojIHN1bW1h cnkgLSBiaXQgdmVjdG9yIGdpdmluZyBhIHN1bW1hcnkgb2YgdGhlIHNpZ25hdHVyZSBzdGF0dXMK IyB2YWxpZGl0eSAtIAojIHZhbGlkaXR5X3JlYXNvbiAtIAojCiMgZnJvbV9rZXk6IHRoZSBrZXkg dXNlZCB0byBnZW5lcmF0ZSB0aGUgc2lnbmF0dXJlCiMKIwoKI2RlYnVnICJzaWcgZnByIGlzICN7 c2lnbmF0dXJlLmZpbmdlcnByaW50fSIKCiNmcm9tX2tleS5zdWJrZXlzLmVhY2gge3xza3wgZGVi dWcgInN1YmtleToga2V5aWQgI3tzay5rZXlpZH0gZnByOiAje3NrLmZwcn0iIH0KCmV4dHJhX2xp bmVzID0gW10KCmlmIChzaWduYXR1cmUuc3VtbWFyeSAmIEdQR01FOjpHUEdNRV9TSUdTVU1fVkFM SUQpICE9IDAKICBjYXNlIHNpZ25hdHVyZS52YWxpZGl0eQogIHdoZW4gR1BHTUU6OkdQR01FX1ZB TElESVRZX0ZVTEwKICAgIGV4dHJhX2xpbmVzIDw8ICJWYWxpZCBzaWduYXR1cmUgZnJvbSBhIGZ1 bGx5IHRydXN0ZWQga2V5IgogIHdoZW4gR1BHTUU6OkdQR01FX1ZBTElESVRZX01BUkdJTkFMCiAg ICBleHRyYV9saW5lcyA8PCAiVmFsaWQgc2lnbmF0dXJlIGZyb20gYSBtYXJnaW5hbGx5IHRydXN0 ZWQga2V5IgogIGVuZAplbHNpZiAoc2lnbmF0dXJlLnN1bW1hcnkgJiBHUEdNRTo6R1BHTUVfU0lH U1VNX0dSRUVOKSAhPSAwCiAgIyBzaWduYXR1cmUgaXMgbW9zdGx5IGdvb2QgLi4uCiAgIyBjb3Vs ZCBiZSBzaWcgZXhwaXJlZCBvciBrZXkgZXhwaXJlZAplbHNpZiAoc2lnbmF0dXJlLnN1bW1hcnkg JiBHUEdNRTo6R1BHTUVfU0lHU1VNX1JFRCkgIT0gMAogICMgc2lnbmF0dXJlIGlzIG1vc3RseSBi YWQgLi4uCiAgY2FzZSBzaWduYXR1cmUudmFsaWRpdHkKICB3aGVuIEdQR01FOjpHUEdNRV9WQUxJ RElUWV9ORVZFUgogICAgZXh0cmFfbGluZXMgPDwgIlNpZ25hdHVyZSBmcm9tIGEga2V5IHRoYXQg aXMgbmV2ZXIgdHJ1c3RlZCIKICBlbmQKICAjIGNvdWxkIGJlIGJhZCBzaWduYXR1cmUKZWxzZQog ICMgdW5rbm93bgogIGV4dHJhX2xpbmVzIDw8ICJHUEcgY2Fubm90IHRlbGwgd2hldGhlciB0aGlz IHNpZ25hdHVyZSBpcyB2YWxpZCIKZW5kCg== --0016363b8edc15709a04953399c7 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel --0016363b8edc15709a04953399c7--