Re: [sup-devel] [PATCH] Converted crypto to use the gpgme gem

From: Hamish D <dmishd@gmail.com>
To: Sup developer discussion <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] Converted crypto to use the gpgme gem
Date: Tue, 16 Nov 2010 23:05:50 +0000	[thread overview]
Message-ID: <AANLkTin=1MRrW0vuj_7uMvjcyLc3Aaw4ddZ_Rq6TBiyx@mail.gmail.com> (raw)
In-Reply-To: <1289932061-sup-96@meteor.durcheinandertal.local>

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

> This does not work for me when running the foobacca/gpgme tree (commit
> 7b9a1eeeaaa25931963e2de49410d7cb0c7e6772). The CryptoNotice is empty.

Oops. I had one too many flatten! calls and was using the
output_lines.flatten! as a return value. However flatten! returns nil
if there is no flattening to be done. I've now fixed this in the
github tree. Please try it out and let me know how it works for you.

>> I am also working on having extra information generated when the key
>> is not trusted, but this is not done yet. And I am also working on a
>> hook where you can generate as much information as you want from the
>> signature for the CryptoNotice. Hopefully be ready to submit before
>> the weekend.
>
> This sounds nice. Thanks for your work!

And thank you for your testing and patience :)

The github version also has the sig-output hook set up. From the hook text:

START
Runs when the signature output is being generated, allowing you to
add extra information to your signatures if you want.

Variables:
signature: the signature object (class is GPGME::Signature)
from_key: the key that generated the signature (class is GPGME::Key)

Return value: an array of lines of output
END

I've attached a sample hook file if you want to have a play with it.
I'll document this all on the wiki if it gets accepted.

I'll give you a few days to find some more problems, but if you fail
to find any then I'll package this up as a single patch and resubmit
it all.

Hamish

[-- Attachment #2: sig-output.rb --]
[-- Type: application/x-ruby, Size: 1222 bytes --]

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel