Archive of RubyForge sup-devel mailing list
 help / color / mirror / Atom feed
From: Hamish D <dmishd@gmail.com>
To: sup-devel@rubyforge.org
Subject: [sup-devel] [PATCH] Stop double quoting the protocol when sending encrypted emails
Date: Fri, 22 Oct 2010 16:37:58 +0100	[thread overview]
Message-ID: <AANLkTimk4yTtJxDj5+H4HfjthdPLQtvE=9enx6GQykRo@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

Some friends of mine were having trouble with encrypted messages of
mine sent by sup. From the commit message:


Stop double quoting the protocol when sending encrypted emails

It was the case that when encrypting emails, the content-type
header line would look like:
Content-Type: multipart/encrypted;
boundary="=-1287680456-54319-281-6673-1-=";
protocol=""application/pgp-encrypted""
It appears that rmail adds the extra quotes, so this change
makes the protocol unquoted to start with, so we end up with
correct quoting.


Hamish Downer

[-- Attachment #2: 0001-Stop-double-quoting-the-protocol-when-sending-encryp.patch --]
[-- Type: text/x-patch, Size: 1164 bytes --]

From 85a532b6f7e598b5cfde34b221992d5a3f90733f Mon Sep 17 00:00:00 2001
From: Hamish Downer <dmishd@gmail.com>
Date: Fri, 22 Oct 2010 16:18:10 +0100
Subject: [PATCH] Stop double quoting the protocol when sending encrypted emails

It was the case that when encrypting emails, the content-type
header line would look like:
Content-Type: multipart/encrypted; boundary="=-1287680456-54319-281-6673-1-="; protocol=""application/pgp-encrypted""
It appears that rmail adds the extra quotes, so this change
makes the protocol unquoted to start with, so we end up with
correct quoting.
---
 lib/sup/crypto.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/sup/crypto.rb b/lib/sup/crypto.rb
index bce01d1..c7b57c1 100644
--- a/lib/sup/crypto.rb
+++ b/lib/sup/crypto.rb
@@ -88,7 +88,7 @@ EOS
     control.body = "Version: 1\n"
 
     envelope = RMail::Message.new
-    envelope.header["Content-Type"] = 'multipart/encrypted; protocol="application/pgp-encrypted"'
+    envelope.header["Content-Type"] = 'multipart/encrypted; protocol=application/pgp-encrypted'
 
     envelope.add_part control
     envelope.add_part encrypted_payload
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel

             reply	other threads:[~2010-10-22 16:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-22 15:37 Hamish D [this message]
2010-11-04 16:04 ` Rich Lane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimk4yTtJxDj5+H4HfjthdPLQtvE=9enx6GQykRo@mail.gmail.com' \
    --to=dmishd@gmail.com \
    --cc=sup-devel@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox