Archive of RubyForge sup-devel mailing list
 help / color / mirror / Atom feed
* [sup-devel] Ruby 1.9.2 Rakefile & LOAD_PATH
@ 2011-03-21 18:38 Matti Eiden
  2011-08-22 11:30 ` Gaute Hope
  0 siblings, 1 reply; 2+ messages in thread
From: Matti Eiden @ 2011-03-21 18:38 UTC (permalink / raw)
  To: sup-devel

Hey folks,

I posted on sup-talk in last December about an issue in the Rakefile
of sup when it comes to Ruby 1.9.2. The whole thing boils down to
this: https://rails.lighthouseapp.com/projects/8994/tickets/2921

Ruby 1.9.2 doesn't include the "." into LOAD_PATH anymore. Would
anybody like to fix this in the master? The fix is simple, just adding
"./" in front of the paths of the sup-version.rb and sup-files.rb. I
don't see why this would affect earlier Ruby versions in a negative
way, but of course I recommend testing it works before commiting to
the git.

Made merge request @ http://gitorious.org/sup/mainline/merge_requests/11

Patch also below.

Regards,
Matti Eiden



diff -aur sup-build/Rakefile sup-build.new/Rakefile
--- sup-build/Rakefile	2011-03-21 19:44:57.000000000 +0200
+++ sup-build.new/Rakefile	2011-03-21 19:52:37.000000000 +0200
@@ -31,8 +31,8 @@

 $:.push "lib"
 require 'rubygems'
-require "sup-files"
-require "sup-version"
+require "./sup-files"
+require "./sup-version"
 require 'rake/gempackagetask.rb'

 spec = Gem::Specification.new do |s|
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [sup-devel] Ruby 1.9.2 Rakefile & LOAD_PATH
  2011-03-21 18:38 [sup-devel] Ruby 1.9.2 Rakefile & LOAD_PATH Matti Eiden
@ 2011-08-22 11:30 ` Gaute Hope
  0 siblings, 0 replies; 2+ messages in thread
From: Gaute Hope @ 2011-08-22 11:30 UTC (permalink / raw)
  To: sup-devel


[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]

Excerpts from Matti Eiden's message of 2011-03-21 19:38:31 +0100:
> I posted on sup-talk in last December about an issue in the Rakefile
> of sup when it comes to Ruby 1.9.2. The whole thing boils down to
> this: https://rails.lighthouseapp.com/projects/8994/tickets/2921
> 
> Made merge request @ http://gitorious.org/sup/mainline/merge_requests/11

Hi,

this still persists.. here is another alternative using
require_relative. Please apply original or my modified, works for me on
latest next.

Best regards,
Gaute

[-- Attachment #1.2: 0001-Rakefile-Require-sup-from-relative-dir.patch --]
[-- Type: application/octet-stream, Size: 627 bytes --]

From 57aba5a12baf48b3173c0568f624f7f16912bb38 Mon Sep 17 00:00:00 2001
From: Gaute Hope <eg@gaute.vetsj.com>
Date: Mon, 22 Aug 2011 13:26:27 +0200
Subject: [PATCH] Rakefile: Require sup-* from relative dir

---
 Rakefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Rakefile b/Rakefile
index d88fd8d..860f69b 100644
--- a/Rakefile
+++ b/Rakefile
@@ -31,8 +31,8 @@ end
 
 $:.push "lib"
 require 'rubygems'
-require "sup-files"
-require "sup-version"
+require_relative "sup-files"
+require_relative "sup-version"
 require 'rake/gempackagetask.rb'
 
 spec = Gem::Specification.new do |s|
-- 
1.7.6


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-22 11:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-21 18:38 [sup-devel] Ruby 1.9.2 Rakefile & LOAD_PATH Matti Eiden
2011-08-22 11:30 ` Gaute Hope

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox