Archive of RubyForge sup-devel mailing list
 help / color / mirror / Atom feed
From: Hamish D <dmishd@gmail.com>
To: Sup developer discussion <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCH] Converted crypto to use the gpgme gem
Date: Tue, 16 Nov 2010 14:20:03 +0000	[thread overview]
Message-ID: <AANLkTi=xz16ecZ0C5=RUcOG4wzojVVzs70PZ2ueKa0ht@mail.gmail.com> (raw)
In-Reply-To: <1289907535-sup-3989@meteor.durcheinandertal.local>

> The "+" character is right in front of the string "Good signature from
> ...". If you move the cursor to that line and press enter it changes
> to a "-" character, but no additional text is shown. The gpg command
> output used to show up there when pressing enter.
>
> I expect there to be some additional output about the signature
> validation like keyid, signature date, trust level, ...

Right, now I know what you are referring to. It is a CryptoNotice
object. That didn't work in the first version of the patch, but I
fixed it in the patch I submitted the second time.

So with the patches submitted in the message with time stamp "8
November 2010 22:32" there will be lines when you expand, telling you
the key ID, the timestamp of the signature and all names and email
addresses associated with that key.

I am also working on having extra information generated when the key
is not trusted, but this is not done yet. And I am also working on a
hook where you can generate as much information as you want from the
signature for the CryptoNotice. Hopefully be ready to submit before
the weekend.

While doing this I'm wondering about the preferred way of submitting
patches that represent quite a bit of work. Should I use git rebase -i
to just have a single patch with all changes, or is it preferred to
have a series of smaller changes?

I also have my code at http://github.com/foobacca/sup - this patch is
being developed in the gpgme branch -
https://github.com/foobacca/sup/tree/gpgme

Hamish
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel

  reply	other threads:[~2010-11-16 16:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06 20:08 Hamish D
2010-11-08 11:21 ` Hamish D
2010-11-08 22:32   ` Hamish D
2010-11-11  9:09     ` Gaudenz Steinlin
2010-11-11 17:25       ` Hamish D
2010-11-16 11:42         ` Gaudenz Steinlin
2010-11-16 14:20           ` Hamish D [this message]
2010-11-16 18:36             ` Gaudenz Steinlin
2010-11-16 23:05               ` Hamish D
2010-11-28 22:51                 ` Hamish D
2010-11-29  9:41                   ` Gaudenz Steinlin
2010-11-30  6:22                     ` Tero Tilus
2010-12-01  8:37                       ` Gaudenz Steinlin
2010-12-06 23:31                     ` Hamish D
2010-12-23 18:43                       ` Rich Lane
2011-01-19  3:11                         ` Rich Lane
2011-01-30 23:57                     ` Hamish D
2011-01-30 23:59                       ` Hamish D
2011-01-19 16:12                   ` Alvaro Herrera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=xz16ecZ0C5=RUcOG4wzojVVzs70PZ2ueKa0ht@mail.gmail.com' \
    --to=dmishd@gmail.com \
    --cc=sup-devel@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox