* [sup-devel] [PATCH] Bugfix: Don’t display thread participants twice
@ 2010-10-07 17:21 Michael Stapelberg
2010-10-08 4:17 ` Rich Lane
0 siblings, 1 reply; 6+ messages in thread
From: Michael Stapelberg @ 2010-10-07 17:21 UTC (permalink / raw)
To: Rich Lane; +Cc: sup-devel
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
Hi,
Quote from the commit message:
When a participant of a thread uses different email addresses, but the same
name, he would be displayed twice in the list:
Participants:
• foo <foo@bar.com>
• foo <foo@qux.bar.com>
• bar <bar@bar.com>
would lead to: "foo, bar, foo"
Best regards,
Michael
[-- Attachment #2: 0001-Bugfix-Don-t-display-thread-participants-twice.patch --]
[-- Type: application/octet-stream, Size: 1198 bytes --]
From 8d18bd3147c7acaa43f76915bdf99bbf10429851 Mon Sep 17 00:00:00 2001
From: Michael Stapelberg <michael@stapelberg.de>
Date: Thu, 7 Oct 2010 17:24:38 +0200
Subject: [PATCH] =?UTF-8?q?Bugfix:=20Don=E2=80=99t=20display=20thread=20participants=20twice?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
When a participant of a thread uses different email addresses, but the same
name, he would be displayed twice in the list:
Participants:
• foo <foo@bar.com>
• foo <foo@qux.bar.com>
• bar <bar@bar.com>
would lead to: "foo, bar, foo"
---
lib/sup/modes/thread-index-mode.rb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/sup/modes/thread-index-mode.rb b/lib/sup/modes/thread-index-mode.rb
index 0c7a3f2..b3f6c77 100644
--- a/lib/sup/modes/thread-index-mode.rb
+++ b/lib/sup/modes/thread-index-mode.rb
@@ -792,8 +792,8 @@ protected
authors = t.map do |m, *o|
next unless m && m.from
new[m.from] ||= m.has_label?(:unread)
- next if seen[m.from]
- seen[m.from] = true
+ next if seen[m.from.mediumname]
+ seen[m.from.mediumname] = true
m.from
end.compact
--
1.7.1
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [sup-devel] [PATCH] Bugfix: Don’t display thread participants twice
2010-10-07 17:21 [sup-devel] [PATCH] Bugfix: Don’t display thread participants twice Michael Stapelberg
@ 2010-10-08 4:17 ` Rich Lane
2010-10-08 10:05 ` Gaute Hope
0 siblings, 1 reply; 6+ messages in thread
From: Rich Lane @ 2010-10-08 4:17 UTC (permalink / raw)
To: Michael Stapelberg; +Cc: sup-devel
Excerpts from Michael Stapelberg's message of Thu Oct 07 13:21:26 -0400 2010:
> Hi,
>
> Quote from the commit message:
> When a participant of a thread uses different email addresses, but the same
> name, he would be displayed twice in the list:
> Participants:
> • foo <foo@bar.com>
> • foo <foo@qux.bar.com>
> • bar <bar@bar.com>
> would lead to: "foo, bar, foo"
>
> Best regards,
> Michael
Applied to master.
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [sup-devel] [PATCH] Bugfix: Don’t display thread participants twice
2010-10-08 4:17 ` Rich Lane
@ 2010-10-08 10:05 ` Gaute Hope
2010-10-08 11:41 ` Michael Stapelberg
2010-10-08 12:07 ` Ben Walton
0 siblings, 2 replies; 6+ messages in thread
From: Gaute Hope @ 2010-10-08 10:05 UTC (permalink / raw)
To: Sup developer discussion, Rich Lane; +Cc: Michael Stapelberg
On Fri, Oct 8, 2010 at 6:17 AM, Rich Lane <rlane@club.cc.cmu.edu> wrote:
> Excerpts from Michael Stapelberg's message of Thu Oct 07 13:21:26 -0400 2010:
>> Hi,
>>
>> Quote from the commit message:
>> When a participant of a thread uses different email addresses, but the same
>> name, he would be displayed twice in the list:
>> Participants:
>> • foo <foo@bar.com>
>> • foo <foo@qux.bar.com>
>> • bar <bar@bar.com>
>> would lead to: "foo, bar, foo"
>>
>> Best regards,
>> Michael
>
> Applied to master.
What if someone has the same name ? ;) Is it more
important/likely/intuitive than anyone using two addresses?
- gaute
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [sup-devel] [PATCH] Bugfix: Don’t display thread participants twice
2010-10-08 10:05 ` Gaute Hope
@ 2010-10-08 11:41 ` Michael Stapelberg
2010-10-08 11:46 ` Gaute Hope
2010-10-08 12:07 ` Ben Walton
1 sibling, 1 reply; 6+ messages in thread
From: Michael Stapelberg @ 2010-10-08 11:41 UTC (permalink / raw)
To: Gaute Hope; +Cc: Sup developer discussion, Rich Lane
Hi Gaute,
Excerpts from Gaute Hope's message of 2010-10-08 12:05:29 +0200:
> What if someone has the same name ? ;) Is it more
> important/likely/intuitive than anyone using two addresses?
If two people have exactly the same name, you would not benefit in seeing that
same name twice, either. Even if one mail of the thread is new and one "Michael
S." is highlighted, you still would not know which one sent the new mail. So,
to avoid confusion about the same name showing up twice, I decided it would be
better to not show duplicates at all.
Best regards,
Michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [sup-devel] [PATCH] Bugfix: Don’t display thread participants twice
2010-10-08 11:41 ` Michael Stapelberg
@ 2010-10-08 11:46 ` Gaute Hope
0 siblings, 0 replies; 6+ messages in thread
From: Gaute Hope @ 2010-10-08 11:46 UTC (permalink / raw)
To: Michael Stapelberg; +Cc: Sup developer discussion, Rich Lane
On Fri, Oct 8, 2010 at 1:41 PM, Michael Stapelberg
<michael+sup@stapelberg.de> wrote:
> Hi Gaute,
>
> Excerpts from Gaute Hope's message of 2010-10-08 12:05:29 +0200:
>> What if someone has the same name ? ;) Is it more
>> important/likely/intuitive than anyone using two addresses?
> If two people have exactly the same name, you would not benefit in seeing that
> same name twice, either. Even if one mail of the thread is new and one "Michael
> S." is highlighted, you still would not know which one sent the new mail. So,
> to avoid confusion about the same name showing up twice, I decided it would be
> better to not show duplicates at all.
Sure, this isn't really a big issue (for me at least). The duplicates
would be the expected behaviour (for me :)), the benefit being that
you know there is one more guy/emailaccount at work here.
Best regards, Gaute
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [sup-devel] [PATCH] Bugfix: Don’t display thread participants twice
2010-10-08 10:05 ` Gaute Hope
2010-10-08 11:41 ` Michael Stapelberg
@ 2010-10-08 12:07 ` Ben Walton
1 sibling, 0 replies; 6+ messages in thread
From: Ben Walton @ 2010-10-08 12:07 UTC (permalink / raw)
To: sup-devel
Excerpts from Gaute Hope's message of Fri Oct 08 06:05:29 -0400 2010:
> What if someone has the same name ? ;) Is it more
> important/likely/intuitive than anyone using two addresses?
A good point, but I'd still rather see a shorter list. The space is
limited, so squashing duplicate names is fine with me.
HTH.
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-08 12:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-07 17:21 [sup-devel] [PATCH] Bugfix: Don’t display thread participants twice Michael Stapelberg
2010-10-08 4:17 ` Rich Lane
2010-10-08 10:05 ` Gaute Hope
2010-10-08 11:41 ` Michael Stapelberg
2010-10-08 11:46 ` Gaute Hope
2010-10-08 12:07 ` Ben Walton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox