* [sup-devel] check keys before sending
@ 2014-05-10 8:23 Troy Sankey
2014-05-10 16:54 ` Gaute Hope
0 siblings, 1 reply; 2+ messages in thread
From: Troy Sankey @ 2014-05-10 8:23 UTC (permalink / raw)
To: sup-devel
[-- Attachment #1.1: Type: text/plain, Size: 1358 bytes --]
Hi sup developers,
Recently I sent an encrypted message to a group of recipients, thinking
that all their keys were still valid. However, one of them had an
expired key, so the message was not encrypted to that recipient and he
could not read it.
I want sup to prompt the user about potentially invalid keys before
sending a message. I think the code will look something like this:
diff --git a/lib/sup/crypto.rb b/lib/sup/crypto.rb
index fd8f824..88ae3cc 100644
--- a/lib/sup/crypto.rb
+++ b/lib/sup/crypto.rb
@@ -167,6 +167,14 @@ EOS
{:operation => "encrypt", :options => gpg_opts}) || gpg_opts
recipients = to + [from]
recipients = HookManager.run("gpg-expand-keys", { :recipients => recipients }) || recipients
+
+ # make sure all recipients can be encrypted-to
+ recipients.each do |recipient|
+ if GPGME::Key.find(:public, recipient).length == 0 and !BufferManager.ask_yes_or_no("Could not encrypt to #{recipient}. Really send?")
+ raise Error, "Send message cancelled."
+ end
+ end
+
begin
if GPGME.respond_to?('encrypt')
cipher = GPGME.encrypt(recipients, format_payload(payload), gpg_opts)
I have not tested this patch, so if it looks wrong then it probably is!
Does anybody have any thoughts on this feature?
Troy
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [sup-devel] check keys before sending
2014-05-10 8:23 [sup-devel] check keys before sending Troy Sankey
@ 2014-05-10 16:54 ` Gaute Hope
0 siblings, 0 replies; 2+ messages in thread
From: Gaute Hope @ 2014-05-10 16:54 UTC (permalink / raw)
To: Sup developer discussion
[-- Attachment #1: Type: text/plain, Size: 1719 bytes --]
I think this can be included if you test and verify the patch. Definetely
very useful.
On Sat, May 10, 2014 at 10:23 AM, Troy Sankey <sankeytms@gmail.com> wrote:
> Hi sup developers,
>
> Recently I sent an encrypted message to a group of recipients, thinking
> that all their keys were still valid. However, one of them had an
> expired key, so the message was not encrypted to that recipient and he
> could not read it.
>
> I want sup to prompt the user about potentially invalid keys before
> sending a message. I think the code will look something like this:
>
>
> diff --git a/lib/sup/crypto.rb b/lib/sup/crypto.rb
> index fd8f824..88ae3cc 100644
> --- a/lib/sup/crypto.rb
> +++ b/lib/sup/crypto.rb
> @@ -167,6 +167,14 @@ EOS
> {:operation => "encrypt", :options =>
> gpg_opts}) || gpg_opts
> recipients = to + [from]
> recipients = HookManager.run("gpg-expand-keys", { :recipients =>
> recipients }) || recipients
> +
> + # make sure all recipients can be encrypted-to
> + recipients.each do |recipient|
> + if GPGME::Key.find(:public, recipient).length == 0 and
> !BufferManager.ask_yes_or_no("Could not encrypt to #{recipient}. Really
> send?")
> + raise Error, "Send message cancelled."
> + end
> + end
> +
> begin
> if GPGME.respond_to?('encrypt')
> cipher = GPGME.encrypt(recipients, format_payload(payload),
> gpg_opts)
>
>
> I have not tested this patch, so if it looks wrong then it probably is!
> Does anybody have any thoughts on this feature?
>
> Troy
>
> _______________________________________________
> Sup-devel mailing list
> Sup-devel@rubyforge.org
> http://rubyforge.org/mailman/listinfo/sup-devel
>
>
[-- Attachment #2: Type: text/html, Size: 2430 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-10 16:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-10 8:23 [sup-devel] check keys before sending Troy Sankey
2014-05-10 16:54 ` Gaute Hope
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox