Archive of RubyForge sup-devel mailing list
 help / color / mirror / Atom feed
* Re: [sup] Maildir root: Keep labels in sync with maildir folders (#253)
       [not found] ` <sup-heliotrope/sup/pull/253/c37732781@github.com>
@ 2014-03-17  7:52   ` Gaute Hope
  2014-03-27 23:40     ` [sup-devel] " Steven Schmeiser
  0 siblings, 1 reply; 4+ messages in thread
From: Gaute Hope @ 2014-03-17  7:52 UTC (permalink / raw)
  To: reply+i-29255720-2f90e7df9a1ebffb4adeb584fd8e35ba4ff1465a-56827; +Cc: sup-devel

Excerpts from Matthieu Rakotojaona's message of 2014-03-15 18:53:10 +0100:
> Just opened https://github.com/sup-heliotrope/sup/tree/maildir-root
> branch at 3f6bc97a14f8e87f1663f924aca5333617cbeec7 (your HEAD) to
> track development of maildir-root. I'd like to use it in instead of
> `gmail_source` because even if I break my sup, I can still read my
> mails with any other MUA in the world.
>
> --- Reply to this email directly or view it on GitHub:
> https://github.com/sup-heliotrope/sup/pull/253#issuecomment-37732781

Cool. Feel free to push fixes there.

That was definetly a strong motivation for me as well.

- gaute



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [sup-devel] [sup] Maildir root: Keep labels in sync with maildir folders (#253)
  2014-03-17  7:52   ` [sup] Maildir root: Keep labels in sync with maildir folders (#253) Gaute Hope
@ 2014-03-27 23:40     ` Steven Schmeiser
  2014-03-28  7:47       ` Matthieu Rakotojaona
  2014-04-03 20:16       ` Matthieu Rakotojaona
  0 siblings, 2 replies; 4+ messages in thread
From: Steven Schmeiser @ 2014-03-27 23:40 UTC (permalink / raw)
  To: Sup developer discussion

I'm trying out the maildir-root branch, but get the following error:

undefined local variable or method `check_enable_experimental' for MaildirSub (deleted):Redwood::MaildirRoot::MaildirSub
/usr/local/Cellar/ruby193/1.9.3-p545/lib/ruby/gems/1.9.1/gems/sup-999/lib/sup/maildirroot.rb:153:in `ensure_maildir'

I did a diff with an older version of maildir-root that I was using from gauteh's personal repository, but I didn't see anything obviously related to this that changed in maildirroot.rb.  Any suggestions?

Thanks,
steve 


On Mar 17, 2014, at 3:52, Gaute Hope <eg@gaute.vetsj.com> wrote:

> Excerpts from Matthieu Rakotojaona's message of 2014-03-15 18:53:10 +0100:
>> Just opened https://github.com/sup-heliotrope/sup/tree/maildir-root
>> branch at 3f6bc97a14f8e87f1663f924aca5333617cbeec7 (your HEAD) to
>> track development of maildir-root. I'd like to use it in instead of
>> `gmail_source` because even if I break my sup, I can still read my
>> mails with any other MUA in the world.
>> 
>> --- Reply to this email directly or view it on GitHub:
>> https://github.com/sup-heliotrope/sup/pull/253#issuecomment-37732781
> 
> Cool. Feel free to push fixes there.
> 
> That was definetly a strong motivation for me as well.
> 
> - gaute
> 
> _______________________________________________
> Sup-devel mailing list
> Sup-devel@rubyforge.org
> http://rubyforge.org/mailman/listinfo/sup-devel
> 

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [sup-devel] [sup] Maildir root: Keep labels in sync with maildir folders (#253)
  2014-03-27 23:40     ` [sup-devel] " Steven Schmeiser
@ 2014-03-28  7:47       ` Matthieu Rakotojaona
  2014-04-03 20:16       ` Matthieu Rakotojaona
  1 sibling, 0 replies; 4+ messages in thread
From: Matthieu Rakotojaona @ 2014-03-28  7:47 UTC (permalink / raw)
  To: sup-devel


[-- Attachment #1.1: Type: text/plain, Size: 957 bytes --]

Excerpts from Steven Schmeiser's message of 2014-03-28 00:40:18 +0100:
> I'm trying out the maildir-root branch, but get the following error:
> 
> undefined local variable or method `check_enable_experimental' for MaildirSub (deleted):Redwood::MaildirRoot::MaildirSub
> /usr/local/Cellar/ruby193/1.9.3-p545/lib/ruby/gems/1.9.1/gems/sup-999/lib/sup/maildirroot.rb:153:in `ensure_maildir'
> 
> I did a diff with an older version of maildir-root that I was using from gauteh's personal repository, but I didn't see anything obviously related to this that changed in maildirroot.rb.  Any suggestions?

Yes, the `check_enable_experimental` function is defined at the
maildirroot level, not the maildirsub level. The whole
e8bc811bb9188cbe9c2111b9515110a90278c46e commit is wrong.

If you feel adventurous you can fix this: the 2 lines are related to the
@maildirroot variable. I'll provide a patch a fix after $dayjob.

-- 
Matthieu Rakotojaona

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [sup-devel] [sup] Maildir root: Keep labels in sync with maildir folders (#253)
  2014-03-27 23:40     ` [sup-devel] " Steven Schmeiser
  2014-03-28  7:47       ` Matthieu Rakotojaona
@ 2014-04-03 20:16       ` Matthieu Rakotojaona
  1 sibling, 0 replies; 4+ messages in thread
From: Matthieu Rakotojaona @ 2014-04-03 20:16 UTC (permalink / raw)
  To: Steven Schmeiser; +Cc: Sup developer discussion


[-- Attachment #1.1: Type: text/plain, Size: 234 bytes --]

Hey Steven,

Turns out that $dayjob was far longer than expected.

I've pushed a PR at https://github.com/sup-heliotrope/sup/pull/286 that
should solve your issue. Could you please have a go at it ?

-- 
Matthieu Rakotojaona

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-04-03 20:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <sup-heliotrope/sup/pull/253@github.com>
     [not found] ` <sup-heliotrope/sup/pull/253/c37732781@github.com>
2014-03-17  7:52   ` [sup] Maildir root: Keep labels in sync with maildir folders (#253) Gaute Hope
2014-03-27 23:40     ` [sup-devel] " Steven Schmeiser
2014-03-28  7:47       ` Matthieu Rakotojaona
2014-04-03 20:16       ` Matthieu Rakotojaona

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox