From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.58.247.3 with SMTP id ya3csp466066vec; Tue, 28 Aug 2012 17:42:26 -0700 (PDT) Received: by 10.60.2.131 with SMTP id 3mr13811517oeu.59.1346200946195; Tue, 28 Aug 2012 17:42:26 -0700 (PDT) Return-Path: Received: from rubyforge.org (50-56-192-79.static.cloud-ips.com. [50.56.192.79]) by mx.google.com with ESMTP id lr6si21164910obb.34.2012.08.28.17.42.25; Tue, 28 Aug 2012 17:42:26 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 50.56.192.79 as permitted sender) client-ip=50.56.192.79; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 50.56.192.79 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from localhost.localdomain (localhost [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 9A40C2E06B; Wed, 29 Aug 2012 00:42:25 +0000 (UTC) Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU [18.7.68.36]) by rubyforge.org (Postfix) with ESMTP id 377EF2E069 for ; Wed, 29 Aug 2012 00:41:17 +0000 (UTC) X-AuditID: 12074424-b7fa06d0000008c2-27-503d652d7600 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP id BF.47.02242.D256D305; Tue, 28 Aug 2012 20:41:17 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q7T0fH4h003892; Tue, 28 Aug 2012 20:41:17 -0400 Received: from localhost (c-67-186-133-183.hsd1.ma.comcast.net [67.186.133.183]) (authenticated bits=0) (User authenticated as ezyang@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q7T0fGb1000467; Tue, 28 Aug 2012 20:41:16 -0400 (EDT) To: sup-devel , btricha From: "Edward Z. Yang" References: <1346200502-27650-1-git-send-email-ezyang@mit.edu> In-reply-to: <1346200502-27650-1-git-send-email-ezyang@mit.edu> Date: Tue, 28 Aug 2012 20:41:15 -0400 Message-Id: <1346200850-sup-3549@javelin> User-Agent: Sup/git X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsUixG6noqubahtgsOyovMWKtf2sFo+n72F3 YPLYOesuu8e+fROZA5iiuGxSUnMyy1KL9O0SuDIaHz5lKZjHXbFv3yT2BsYGji5GTg4JAROJ 4wcfskLYYhIX7q1n62Lk4hAS2Mco8fTveWYIZwOjxLHrExghnB4miZkzLrF3MXJwMAuoS6yf JwTSLSLgIvHwYis7iM0GFH507CkrSImQgJ3En5dmIGFhAQuJt9O6wUo4Bewlbi5fygxiswio SizbdJ0JxOYV0JRY1HMSLC4qICzx5EgzmM0sIC/RvHU28wRG/lkIi2chySxgZFrFKJuSW6Wb m5iZU5yarFucnJiXl1qka66Xm1mil5pSuokRHHQuKjsYmw8pHWIU4GBU4uE99NcmQIg1say4 MvcQoyQHk5Io78sE2wAhvqT8lMqMxOKM+KLSnNTiQ4wSHMxKIrxPTYFyvCmJlVWpRfkwKWkO FiVx3uspN/2FBNITS1KzU1MLUotgsjIcHEoSvCUpQI2CRanpqRVpmTklCGkmDk6Q4TxAw31B aniLCxJzizPTIfKnGHU5Xs46dZdRiCUvPy9VSpxXG6RIAKQoozQPbg4sWbxiFAd6S5g3EKSK B5ho4Ca9AlrCBLRkv6I1yJKSRISUVANj85WQHBGPPXdtRO7sc8xKuO35/VCh2Vq9+5sesz4p uLtk9qc1v9yWzw3ab77hUnOm5rXgSja3+LSXu5/Uvrx5XNY3cUfDH+ZP3hwlKR2hKU4/yk35 L4c+kxWt0TZ1TmI0Uq39tpD/WP5VQ9n5goo8Aq0SCwV3da3QUUn8Lf7AQNR1V6zwWwklluKM REMt5qLiRAADh/PC8QIAAA== Subject: Re: [sup-devel] [PATCH] Handle drafts with high ID numbers. X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org If you've ever suffered from saving a draft message, and then suddenly asking, "Where did it go?" because it didn't show up in your INBOX, try this patch. Edward Excerpts from Edward Z. Yang's message of Tue Aug 28 20:35:01 -0400 2012: > From: "Edward Z. Yang" > > Signed-off-by: Edward Z. Yang > --- > lib/sup/draft.rb | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/lib/sup/draft.rb b/lib/sup/draft.rb > index 58c45db..1f33dc1 100644 > --- a/lib/sup/draft.rb > +++ b/lib/sup/draft.rb > @@ -37,7 +37,6 @@ class DraftLoader < Source > Dir.mkdir dir unless File.exists? dir > super DraftManager.source_name, true, false > @dir = dir > - @cur_offset = 0 > end > > def id; DraftManager.source_id; end > @@ -46,14 +45,13 @@ class DraftLoader < Source > > def poll > ids = get_ids > - ids.each do |id| > - if id >= @cur_offset > - @cur_offset = id + 1 > - yield :add, > - :info => id, > - :labels => [:draft, :inbox], > - :progress => 0.0 > - end > + old_ids = Enumerator.new(Index.instance, :each_source_info, self.id).to_a > + new_ids = ids - old_ids > + new_ids.each do |id| > + yield :add, > + :info => id, > + :labels => [:draft, :inbox], > + :progress => 0.0 > end > end > _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel