From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.52.72.138 with SMTP id d10cs370122vdv; Thu, 29 Dec 2011 21:59:49 -0800 (PST) Received: by 10.224.192.8 with SMTP id do8mr46211156qab.46.1325224787896; Thu, 29 Dec 2011 21:59:47 -0800 (PST) Return-Path: Received: from rubyforge.org (rubyforge.org. [205.234.109.19]) by mx.google.com with ESMTP id k1si24151448qap.31.2011.12.29.21.59.47; Thu, 29 Dec 2011 21:59:47 -0800 (PST) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 43A41177994F for ; Fri, 30 Dec 2011 00:59:47 -0500 (EST) Received: from masanjin.net (masanjin.net [209.20.72.13]) by rubyforge.org (Postfix) with ESMTP id DCF5D185836C for ; Fri, 30 Dec 2011 00:50:47 -0500 (EST) Received: from w by masanjin.net with local (Exim 4.71) (envelope-from ) id 1RgVj0-0008Ud-Nv; Fri, 30 Dec 2011 06:13:54 +0000 From: William Morgan To: Robin Burchell In-reply-to: References: Date: Thu, 29 Dec 2011 21:50:46 -0800 Message-Id: <1325223938-sup-1516@tw-mbp-wmorgan.local> User-Agent: turnsole, a heliotrope client v.git Cc: sup-devel@rubyforge.org Subject: [sup-devel] Ruby 1.8 compatibility patches for Heliotrope and Turnsole. X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Excerpts from Robin Burchell's message of Tue Dec 13 08:46:30 -0800 2011: > I recently tried Turnsole/Heliotrope from git. I'm forced (thanks to > Fedora) to use Ruby 1.8, and noticed there were at least one issue in > both Heliotrope and Turnsole. Patches attached. Thank you. I've applied the IMAP one. The escapeHTML issue I believe I've fixed elsewise. Please let me know if it doesn't work for you. As for the string encoding error, I'm reluctant to apply string encoding patches like that because they tend to infect the entire codebase. (Sup is a good example of this.) If you can figure out the source of the corrupted string, then we can fix the problem at the point where it's brought into the system rather than having to fix every possible place. > P.S. Did you take a look at > http://www.mail-archive.com/sup-devel@rubyforge.org/msg01071.html ? > I'm interested in two-way sync as much as is sanely possible (both > gmail and regular imap), without it, I sadly don't think I'll ever be > able to become more than a casual observer. I am more than happy that someone is working on this, but it's not a problem I personally want to address. I would rather make Heliotrope so awesome that it's worth switching to, and provide easy exit mechanisms so that you aren't trapped. -- William _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel