From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.142.50.5 with SMTP id x5cs58737wfx; Mon, 20 Jun 2011 14:50:58 -0700 (PDT) Received: by 10.52.157.227 with SMTP id wp3mr341482vdb.275.1308605915868; Mon, 20 Jun 2011 14:38:35 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id k30si3778893vbi.78.2011.06.20.14.38.35; Mon, 20 Jun 2011 14:38:35 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org; dkim=neutral (body hash did not verify) header.i=@gmail.com Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 492DD185838A; Mon, 20 Jun 2011 17:38:35 -0400 (EDT) Received: from mail-wy0-f178.google.com (mail-wy0-f178.google.com [74.125.82.178]) by rubyforge.org (Postfix) with ESMTP id E0B6818581B2 for ; Mon, 20 Jun 2011 17:38:28 -0400 (EDT) Received: by wya21 with SMTP id 21so2341259wya.23 for ; Mon, 20 Jun 2011 14:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:content-type:subject:from:to:in-reply-to :references:date:message-id:user-agent:content-transfer-encoding; bh=TnC4/19XdUg070zSdqFR8tlJZwRlE79+Dv4h5srP0KQ=; b=qYqmjOKX0gtK+vBAb0ZDbhEZ+IVDO4tU3Rkt7PbERfY2bxMwAmW87IoniYztsUJG1A toyWCc2yIImBV6bdY2Dctn2/CfwXUl1dgkScT43VYFRPdIdN47w84vV8SsVs6CL4ymgP bHi5qecNCzNzILkMy0EbdgeYmm4AM/Ovjyp7c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=content-type:subject:from:to:in-reply-to:references:date:message-id :user-agent:content-transfer-encoding; b=NLo/89Yqvs0XTKsTnGPHiHh+R8lvslNlj1OreGSK3Z9U+NQSm0vnf7nrw6OISM0Y56 mnvdgqveaX8BA9T4uJ29NNh3qzRDxyXHCk7FkTHU9oIx3L6i2LIMknbmlv1VyPktUOdm TAZJbkQ+ygoGua/ZRXjua4za8Z8XFYd9lpx/I= Received: by 10.216.229.210 with SMTP id h60mr1427632weq.29.1308605907677; Mon, 20 Jun 2011 14:38:27 -0700 (PDT) Received: from localhost (cpc12-cmbg15-2-0-cust81.5-4.cable.virginmedia.com [86.30.247.82]) by mx.google.com with ESMTPS id m8sm3501089wbh.62.2011.06.20.14.38.24 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Jun 2011 14:38:25 -0700 (PDT) From: Hamish Downer To: sup-devel In-reply-to: <1308577441-sup-8658@xo15-sascha.sascha.silbe.org> References: <1300032642-sup-9716@mailer> <1306775826-sup-4909@whisper> <1308520036-sup-7949@whisper> <1308577441-sup-8658@xo15-sascha.sascha.silbe.org> Date: Mon, 20 Jun 2011 22:38:21 +0100 Message-Id: <1308605576-sup-2122@whisper> User-Agent: Sup/git Subject: Re: [sup-devel] [PATCHES] Add an account selector in edit-mode X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Excerpts from Sascha Silbe's message of Mon Jun 20 14:47:57 +0100 2011: > This breaks the "Reply to" selector for me. Any attempt to change the > value results in an exception: > > So account_selector.selection is nil. The only way for that to happen is > by calling account_selector.set_to() with a value that's not in > account_selector.vals (IMO HorizontalSelector should throw an exception > in that case, BTW). Any idea where and why that would have happened? I'm afraid I couldn't reproduce your exception - do you have several accounts? Multiple email addresses per account? Anyway I've pushed an update to the account_selector branch (commit 5bb55890) that you could try out. The basic change is that in the original patch, there was: @account_selector = HorizontalSelector.new "Account:", AccountManager.user_accounts + [nil], user_emails_copy + ["Customized"] Note the [nil] added to the end of the first array. I've changed that to [:user] (in line with the replyto selector) and made the other changes in the file to stay in line with that. As I say I can't reproduce your problem, so I'm not 100% sure I've solved it, so let me know how you get on. If it fixes it for you I'll put the patch onto next aswell. Hamish Downer _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel