From: Hamish Downer <dmishd@gmail.com>
To: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCHES] Add an account selector in edit-mode
Date: Mon, 20 Jun 2011 22:38:21 +0100 [thread overview]
Message-ID: <1308605576-sup-2122@whisper> (raw)
In-Reply-To: <1308577441-sup-8658@xo15-sascha.sascha.silbe.org>
Excerpts from Sascha Silbe's message of Mon Jun 20 14:47:57 +0100 2011:
> This breaks the "Reply to" selector for me. Any attempt to change the
> value results in an exception:
>
> So account_selector.selection is nil. The only way for that to happen is
> by calling account_selector.set_to() with a value that's not in
> account_selector.vals (IMO HorizontalSelector should throw an exception
> in that case, BTW). Any idea where and why that would have happened?
I'm afraid I couldn't reproduce your exception - do you have several
accounts? Multiple email addresses per account?
Anyway I've pushed an update to the account_selector branch (commit
5bb55890) that you could try out. The basic change is that in the
original patch, there was:
@account_selector =
HorizontalSelector.new "Account:", AccountManager.user_accounts + [nil], user_emails_copy + ["Customized"]
Note the [nil] added to the end of the first array. I've changed that to
[:user] (in line with the replyto selector) and made the other changes
in the file to stay in line with that. As I say I can't reproduce your
problem, so I'm not 100% sure I've solved it, so let me know how you get
on. If it fixes it for you I'll put the patch onto next aswell.
Hamish Downer
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
prev parent reply other threads:[~2011-06-20 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 16:13 Damien Leone
2011-03-13 20:21 ` Sascha Silbe
2011-05-30 17:23 ` Hamish
2011-06-19 21:48 ` Hamish
2011-06-20 8:08 ` Damien Leone
2011-06-20 13:47 ` Sascha Silbe
2011-06-20 21:38 ` Hamish Downer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308605576-sup-2122@whisper \
--to=dmishd@gmail.com \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox