From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.142.50.5 with SMTP id x5cs35874wfx; Mon, 20 Jun 2011 01:37:01 -0700 (PDT) Received: by 10.220.37.198 with SMTP id y6mr1908450vcd.103.1308559020187; Mon, 20 Jun 2011 01:37:00 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id o11si3309677vcl.151.2011.06.20.01.36.58; Mon, 20 Jun 2011 01:36:59 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org; dkim=neutral (body hash did not verify) header.i=@gmail.com Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 676ED185838E; Mon, 20 Jun 2011 04:36:58 -0400 (EDT) Received: from mail-wy0-f178.google.com (mail-wy0-f178.google.com [74.125.82.178]) by rubyforge.org (Postfix) with ESMTP id 75E1D185834E for ; Mon, 20 Jun 2011 04:08:43 -0400 (EDT) Received: by wya21 with SMTP id 21so1724213wya.23 for ; Mon, 20 Jun 2011 01:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:content-type:subject:from:to:in-reply-to :references:date:message-id:user-agent:content-transfer-encoding; bh=hFOtkYPj8XO7WG584fthAnOWpIaGOy/W3Aa/LqqiBmM=; b=OYv/PTt9tLHOyewJYKW2RvByuvl/jy7qC9FuvrMmVUoSkY4H91jas+LleJ8rEzN2sD I3JnTXgZZWhYEqHiWVZVYQEMvE2qoRQkRrGXGoUHUU2xFaFfbtFL/sxOmm9RYXXX6z0i bFejW9V2rYCCsTHVL0CVXCmLFEmEZBk3mSK6w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:content-type:subject:from:to:in-reply-to:references:date :message-id:user-agent:content-transfer-encoding; b=dmQwIitBZe1hHLfBHklALLLHeAZcFvip8Sf9B+UyXMgmI9l8ynhjUAQhhY2U4uZ9pc DmkWAk1PSb+xlt8QZhAH84B8sPD0Z1AP5AuBgQoto+VovOdaDrxce57alz9dkNIIxwQp 0ZCrJBjWSHJt5WvCZJkso5dcWz8s6v9hNDR7k= Received: by 10.216.173.14 with SMTP id u14mr1126033wel.38.1308557322930; Mon, 20 Jun 2011 01:08:42 -0700 (PDT) Received: from localhost (mut38-4-82-233-117-144.fbx.proxad.net [82.233.117.144]) by mx.google.com with ESMTPS id o75sm2740546weq.40.2011.06.20.01.08.41 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Jun 2011 01:08:41 -0700 (PDT) From: Damien Leone To: sup-devel In-reply-to: <1308520036-sup-7949@whisper> References: <1300032642-sup-9716@mailer> <1306775826-sup-4909@whisper> <1308520036-sup-7949@whisper> Date: Mon, 20 Jun 2011 10:08:39 +0200 Message-Id: <1308557136-sup-5866@mailer> User-Agent: Sup/git Subject: Re: [sup-devel] [PATCHES] Add an account selector in edit-mode X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Hello, Sorry I have been quite busy finishing my degree last weeks. I planned to review and answer but it got delayed and delayed. Thanks for pushing and fixing the issue with alternate addresses. I will fetch it and let you know. Excerpts from Hamish's message of dim. juin 19 23:48:40 +0200 2011: > Excerpts from Hamish's message of Mon May 30 18:23:10 +0100 2011: > > Excerpts from Damien Leone's message of Sun Mar 13 16:13:05 +0000 2011: > > > 0002-edit-message-mode-Add-an-optional-account-selector.patch > > > > I imagine though that you would want to handle all the possible email > > addresses, so I've written an extra patch to do that, and pushed your > > patch and mine onto the (new) account_selector branch on gitorious. > > Please have a look and see if what I've done still works for you, and is > > what you meant. > > > > I also wondered whether to change the behaviour so that the account > > selector will only appear if there is more than one possible email > > address to choose from, but I thought it would be handy to be able to > > reset the From: header to your usual From: using the selector, rather > > than having to hand edit whatever was in the To: header that you are > > replying to. What do you think? > > > > I'll wait for you to review my changes before I merge this into next. > > (My changes are in commit bf56b543cc664c40c3695e287ee8e7e924f2d0d1) > > I've not heard anything for a bit, so I've pushed this into next for > wider testing, with the guard so that the account selector will only > appear if you have more than one email address. Shout out if it causes > any problems. > > Hamish -- Damien Leone GPG: 0x82EB4DDF _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel