From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.142.50.5 with SMTP id x5cs24668wfx; Sun, 19 Jun 2011 14:48:54 -0700 (PDT) Received: by 10.224.201.70 with SMTP id ez6mr3547080qab.176.1308520133476; Sun, 19 Jun 2011 14:48:53 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id fx6si12254559qab.19.2011.06.19.14.48.53; Sun, 19 Jun 2011 14:48:53 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org; dkim=neutral (body hash did not verify) header.i=@gmail.com Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 0AC641858367; Sun, 19 Jun 2011 17:48:53 -0400 (EDT) Received: from mail-ww0-f54.google.com (mail-ww0-f54.google.com [74.125.82.54]) by rubyforge.org (Postfix) with ESMTP id C421B185836C for ; Sun, 19 Jun 2011 17:48:42 -0400 (EDT) Received: by wwf4 with SMTP id 4so1137254wwf.23 for ; Sun, 19 Jun 2011 14:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:content-type:subject:from:to:in-reply-to :references:date:message-id:user-agent:content-transfer-encoding; bh=e/8StOQDjrjh/Rc05VEY/otAwtSNJiHFSyL3sjkggG8=; b=uvUZkyBPx/7QnEY2/qYYBBm8zbV/CuMDQ3ue6TSJ81XUbNC+ZyjoNvroHi44PGlIXD 0RV+j81Ntcigab+a4ZpGiudj2dsxRIHvXQRVUd38M5RWtBRkquAH/0qAnR+0F98MkRq0 1m3iDwP5z2L20IGjWT/C4CH7r1fsdAV6/fpLk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=content-type:subject:from:to:in-reply-to:references:date:message-id :user-agent:content-transfer-encoding; b=bnarRNTYZhkIKZ3p927P96M2EMCt5stJyV/RL4/VhISGVQ+DYRR89gyZ2SuNKBXXMi mSjIkTxW3E8p01UF4DBLTd19i3cGW3ANVKs2Hw6+8yD9T/UgwhNbmCcBU6c2cEk/k885 ionvvWHMMfHaMyixVVT+Q1M4KX06KQ8cGDS6U= Received: by 10.227.206.82 with SMTP id ft18mr4196364wbb.64.1308520121993; Sun, 19 Jun 2011 14:48:41 -0700 (PDT) Received: from localhost (cpc12-cmbg15-2-0-cust81.5-4.cable.virginmedia.com [86.30.247.82]) by mx.google.com with ESMTPS id m8sm2696656wbh.11.2011.06.19.14.48.40 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2011 14:48:41 -0700 (PDT) From: Hamish To: sup-devel In-reply-to: <1306775826-sup-4909@whisper> References: <1300032642-sup-9716@mailer> <1306775826-sup-4909@whisper> Date: Sun, 19 Jun 2011 22:48:40 +0100 Message-Id: <1308520036-sup-7949@whisper> User-Agent: Sup/git Subject: Re: [sup-devel] [PATCHES] Add an account selector in edit-mode X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Excerpts from Hamish's message of Mon May 30 18:23:10 +0100 2011: > Excerpts from Damien Leone's message of Sun Mar 13 16:13:05 +0000 2011: > > 0002-edit-message-mode-Add-an-optional-account-selector.patch > > I imagine though that you would want to handle all the possible email > addresses, so I've written an extra patch to do that, and pushed your > patch and mine onto the (new) account_selector branch on gitorious. > Please have a look and see if what I've done still works for you, and is > what you meant. > > I also wondered whether to change the behaviour so that the account > selector will only appear if there is more than one possible email > address to choose from, but I thought it would be handy to be able to > reset the From: header to your usual From: using the selector, rather > than having to hand edit whatever was in the To: header that you are > replying to. What do you think? > > I'll wait for you to review my changes before I merge this into next. > (My changes are in commit bf56b543cc664c40c3695e287ee8e7e924f2d0d1) I've not heard anything for a bit, so I've pushed this into next for wider testing, with the guard so that the account selector will only appear if you have more than one email address. Shout out if it causes any problems. Hamish _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel