From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.142.52.5 with SMTP id z5cs7465wfz; Mon, 30 May 2011 10:34:32 -0700 (PDT) Received: by 10.52.74.225 with SMTP id x1mr3674644vdv.1.1306776871963; Mon, 30 May 2011 10:34:31 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id bi3si3840848vdb.21.2011.05.30.10.34.31; Mon, 30 May 2011 10:34:31 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org; dkim=neutral (body hash did not verify) header.i=@gmail.com Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 7E32818583BF for ; Mon, 30 May 2011 13:34:31 -0400 (EDT) Received: from mail-ww0-f54.google.com (mail-ww0-f54.google.com [74.125.82.54]) by rubyforge.org (Postfix) with ESMTP id 321F718583BF for ; Mon, 30 May 2011 13:23:20 -0400 (EDT) Received: by wwd20 with SMTP id 20so3672594wwd.23 for ; Mon, 30 May 2011 10:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:content-type:subject:from:to:in-reply-to :references:date:message-id:user-agent:content-transfer-encoding; bh=T0I6mI++yFSES/TIwIogllYKUlhQHVTUgeQ7jh3CGJ8=; b=Usp1XklgSbvLCu8wpMcnvR7yteG49LclDBD4wUiHapfp5Eeielpc+7uT6WZWliCN2J 1BJbJWTSK05z7UWrv0e9khgf5S6AE3FHIxo5sbTfp3pU5M25Tdxs4LGDitiLXG2ZwC54 n2yAWOI5GoVdOCMHXSVOhlEaH8WgwaQauN3e8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=content-type:subject:from:to:in-reply-to:references:date:message-id :user-agent:content-transfer-encoding; b=O3DIyJeXxY2zMBzbkDSaxGmY28IOLSeXEt94lcF6EBHfl56azBIkoUb+Ppp6gzdNwd LDr1x3VMg6LsSbW1Gc1GjLDyzz8Yq5skql6E384L0/spW0RH1HG169wUCgnKztKHfC4J xlEsyDYD5EyX1KBO6n2EykdwV8wVrYm0SzREY= Received: by 10.216.230.138 with SMTP id j10mr2737193weq.46.1306776199838; Mon, 30 May 2011 10:23:19 -0700 (PDT) Received: from localhost (cpc12-cmbg15-2-0-cust81.5-4.cable.virginmedia.com [86.30.247.82]) by mx.google.com with ESMTPS id o75sm2619925weq.16.2011.05.30.10.23.16 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 30 May 2011 10:23:18 -0700 (PDT) From: Hamish To: sup-devel In-reply-to: <1300032642-sup-9716@mailer> References: <1300032642-sup-9716@mailer> Date: Mon, 30 May 2011 18:23:10 +0100 Message-Id: <1306775826-sup-4909@whisper> User-Agent: Sup/git Subject: Re: [sup-devel] [PATCHES] Add an account selector in edit-mode X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org Excerpts from Damien Leone's message of Sun Mar 13 16:13:05 +0000 2011: > 0002-edit-message-mode-Add-an-optional-account-selector.patch I've finally got around to reviewing some of these. The patch above seems to confuse possible email addresses, and user accounts. These do not line up as it is possible for each account to have multiple email addresses associated with it (using the alternates value in an account). I have only one account, and have alternates, so the account selector appears, but doesn't work due to the confusion. I've had a look through, but not found an easy way to fix that behaviour, so I'll leave it up to you as to how you want to do it. I imagine though that you would want to handle all the possible email addresses, so I've written an extra patch to do that, and pushed your patch and mine onto the (new) account_selector branch on gitorious. Please have a look and see if what I've done still works for you, and is what you meant. I also wondered whether to change the behaviour so that the account selector will only appear if there is more than one possible email address to choose from, but I thought it would be handy to be able to reset the From: header to your usual From: using the selector, rather than having to hand edit whatever was in the To: header that you are replying to. What do you think? I'll wait for you to review my changes before I merge this into next. (My changes are in commit bf56b543cc664c40c3695e287ee8e7e924f2d0d1) Hamish Downer _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel