From: Hamish <dmishd@gmail.com>
To: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCHES] Add an account selector in edit-mode
Date: Mon, 30 May 2011 18:23:10 +0100 [thread overview]
Message-ID: <1306775826-sup-4909@whisper> (raw)
In-Reply-To: <1300032642-sup-9716@mailer>
Excerpts from Damien Leone's message of Sun Mar 13 16:13:05 +0000 2011:
> 0002-edit-message-mode-Add-an-optional-account-selector.patch
I've finally got around to reviewing some of these. The patch above
seems to confuse possible email addresses, and user accounts. These do
not line up as it is possible for each account to have multiple email
addresses associated with it (using the alternates value in an account).
I have only one account, and have alternates, so the account selector
appears, but doesn't work due to the confusion. I've had a look through,
but not found an easy way to fix that behaviour, so I'll leave it up to
you as to how you want to do it.
I imagine though that you would want to handle all the possible email
addresses, so I've written an extra patch to do that, and pushed your
patch and mine onto the (new) account_selector branch on gitorious.
Please have a look and see if what I've done still works for you, and is
what you meant.
I also wondered whether to change the behaviour so that the account
selector will only appear if there is more than one possible email
address to choose from, but I thought it would be handy to be able to
reset the From: header to your usual From: using the selector, rather
than having to hand edit whatever was in the To: header that you are
replying to. What do you think?
I'll wait for you to review my changes before I merge this into next.
(My changes are in commit bf56b543cc664c40c3695e287ee8e7e924f2d0d1)
Hamish Downer
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2011-05-30 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 16:13 Damien Leone
2011-03-13 20:21 ` Sascha Silbe
2011-05-30 17:23 ` Hamish [this message]
2011-06-19 21:48 ` Hamish
2011-06-20 8:08 ` Damien Leone
2011-06-20 13:47 ` Sascha Silbe
2011-06-20 21:38 ` Hamish Downer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306775826-sup-4909@whisper \
--to=dmishd@gmail.com \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox