* Re: [sup-devel] heliotrope: Crash with empty message.recipients
[not found] <1303314278-sup-9272@sam.mediasupervision.de>
@ 2011-05-10 17:45 ` William Morgan
2011-05-16 15:56 ` Gregor Hoffleit
0 siblings, 1 reply; 5+ messages in thread
From: William Morgan @ 2011-05-10 17:45 UTC (permalink / raw)
To: sup-devel
Reformatted excerpts from Gregor Hoffleit's message of 2011-04-20:
>
> To: , debian-vote@lists.debian.org
>
> This code in line 482 of lib/heliotrope/index.rb will fail work if any
> recipient is empty:
>
> message.recipients.map { |x| x.indexable_text }.join(" ").downcase
Sorry for the lengthy wait. I believe this has been fixed. Please let me
know if you still encounter this problem!
--
William <wmorgan-sup@masanjin.net>
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-devel] heliotrope: Crash with empty message.recipients
2011-05-10 17:45 ` [sup-devel] heliotrope: Crash with empty message.recipients William Morgan
@ 2011-05-16 15:56 ` Gregor Hoffleit
2011-05-18 14:52 ` William Morgan
0 siblings, 1 reply; 5+ messages in thread
From: Gregor Hoffleit @ 2011-05-16 15:56 UTC (permalink / raw)
To: William Morgan; +Cc: sup-devel
* William Morgan <wmorgan-sup@masanjin.net> [Di Mai 10 19:45:49 +0200 2011]
> Reformatted excerpts from Gregor Hoffleit's message of 2011-04-20:
> >
> > To: , debian-vote@lists.debian.org
> >
> > This code in line 482 of lib/heliotrope/index.rb will fail work if any
> > recipient is empty:
> >
> > message.recipients.map { |x| x.indexable_text }.join(" ").downcase
>
> Sorry for the lengthy wait. I believe this has been fixed. Please let me
> know if you still encounter this problem!
The problem with empty recipient strings is still there, I'm afraid.
Tested today, with current heliotrope from GIT.
Regards,
Gregor
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-devel] heliotrope: Crash with empty message.recipients
2011-05-16 15:56 ` Gregor Hoffleit
@ 2011-05-18 14:52 ` William Morgan
2011-05-18 15:47 ` Gregor Hoffleit
0 siblings, 1 reply; 5+ messages in thread
From: William Morgan @ 2011-05-18 14:52 UTC (permalink / raw)
To: sup-devel
Reformatted excerpts from Gregor Hoffleit's message of 2011-05-16:
> The problem with empty recipient strings is still there, I'm afraid.
> Tested today, with current heliotrope from GIT.
Rats. Can you please add an issue to the heliotrope github issue tracker
so that I don't forget about this?
--
William <wmorgan-sup@masanjin.net>
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [sup-devel] heliotrope: Crash with empty message.recipients
2011-05-18 14:52 ` William Morgan
@ 2011-05-18 15:47 ` Gregor Hoffleit
0 siblings, 0 replies; 5+ messages in thread
From: Gregor Hoffleit @ 2011-05-18 15:47 UTC (permalink / raw)
To: William Morgan; +Cc: sup-devel
* William Morgan <wmorgan-sup@masanjin.net> [Mi Mai 18 16:52:59 +0200 2011]
> Reformatted excerpts from Gregor Hoffleit's message of 2011-05-16:
> > The problem with empty recipient strings is still there, I'm afraid.
> > Tested today, with current heliotrope from GIT.
>
> Rats. Can you please add an issue to the heliotrope github issue tracker
> so that I don't forget about this?
Done. https://github.com/wmorgan/heliotrope/issues/1
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [sup-devel] heliotrope: Crash with empty message.recipients
@ 2011-04-21 10:18 Gregor Hoffleit
0 siblings, 0 replies; 5+ messages in thread
From: Gregor Hoffleit @ 2011-04-21 10:18 UTC (permalink / raw)
To: William Morgan; +Cc: sup-devel
I noticed that heliotrope-add bangs out on message
<E1JZvDB-0000vf-17@faramir.fjphome.nl> from the debian-vote list:
http://lists.debian.org/debian-vote/2008/03/msg00130.html
# ruby1.9.1 -Ilib ./bin/heliotrope-add -m debian-vote-2008 -d test
/home/test/GIT/heliotrope/lib/heliotrope/index.rb:482:in `block in index!': undefined method `indexable_text' for nil:NilClass (NoMethodError)
from /home/test/GIT/heliotrope/lib/heliotrope/index.rb:482:in `map'
from /home/test/GIT/heliotrope/lib/heliotrope/index.rb:482:in `index!'
from /home/test/GIT/heliotrope/lib/heliotrope/index.rb:80:in `add_message'
from ./bin/heliotrope-add:113:in `<main>'
As you can see even in the HTML representation of the message linked
above:
To: , debian-vote@lists.debian.org
This code in line 482 of lib/heliotrope/index.rb will fail work if any
recipient is empty:
message.recipients.map { |x| x.indexable_text }.join(" ").downcase
Sadly, I'm lacking the Ruby skills to make heliotrope cope with such
pathological messages. In Python, I would fix it like this:
[x.indexable_text for x in message.recipients if x]
Regards,
Gregor
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-18 16:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1303314278-sup-9272@sam.mediasupervision.de>
2011-05-10 17:45 ` [sup-devel] heliotrope: Crash with empty message.recipients William Morgan
2011-05-16 15:56 ` Gregor Hoffleit
2011-05-18 14:52 ` William Morgan
2011-05-18 15:47 ` Gregor Hoffleit
2011-04-21 10:18 Gregor Hoffleit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox