From: Gregor Hoffleit <gregor@hoffleit.de>
To: William Morgan <wmorgan-sup@masanjin.net>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] sup-server revisited
Date: Fri, 15 Apr 2011 22:53:21 +0200 [thread overview]
Message-ID: <1302900208-sup-1898@sam.mediasupervision.de> (raw)
In-Reply-To: <1302887129-sup-7325@masanjin.net>
* William Morgan <wmorgan-sup@masanjin.net> [Fr Apr 15 19:16:43 +0200 2011]
> Reformatted excerpts from Gregor Hoffleit's message of 2011-04-15:
> > The source of this problem is in whistlepig's tokenizer. I'm hurt by an
> > overflow in posarray->next and posarray->size, which are defined as
> > uint16_t. I was able to fix my problem by defining these to uint32_t:
>
> Thanks! This is totally good. I will admit I got distracted by some
> other tasks and forgot to come back to this. Maybe that's a sign I
> should start using Github's vaunted issue tracker.
>
> What I don't understand is that the posarray stuff is all for token
> offsets, isn't it? So why would the number of lines actually matter?
> Large messages can overflow this but it should be in terms of tokens,
> not lines.
Yep. In fact the number of lines is a pure coincidence.
The mail that got stuck was a logcheck report, which had 35.000 lines
all starting with the current date. I guess whistlepig tried to append
some 35.000 instances of "Feb" to the posarray, which lead to an
infinite loop.
Regards,
Gregor
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2011-04-15 21:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 21:02 William Morgan
2011-02-22 13:46 ` Mark Alexander
2011-02-22 17:55 ` William Morgan
2011-02-22 18:44 ` Tero Tilus
2011-02-22 19:00 ` William Morgan
2011-02-22 14:09 ` Nicolas Pouillard
2011-02-22 20:17 ` Tero Tilus
2011-02-22 21:29 ` William Morgan
2011-02-23 9:48 ` Nicolas Pouillard
2011-02-23 18:43 ` William Morgan
2011-02-23 18:53 ` Alvaro Herrera
2011-02-23 21:08 ` William Morgan
2011-02-23 21:30 ` Alvaro Herrera
2011-03-03 19:38 ` Sascha Silbe
2011-02-26 19:15 ` Hamish
2011-02-26 22:04 ` William Morgan
2011-02-26 23:15 ` William Morgan
2011-03-01 19:38 ` Hamish
2011-03-02 12:43 ` Gregor Hoffleit
2011-03-02 18:51 ` William Morgan
2011-03-03 17:32 ` Gregor Hoffleit
2011-03-03 19:17 ` William Morgan
2011-04-15 10:46 ` Gregor Hoffleit
2011-04-15 17:16 ` William Morgan
2011-04-15 20:53 ` Gregor Hoffleit [this message]
2011-04-17 16:58 ` William Morgan
2011-04-17 17:55 ` William Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302900208-sup-1898@sam.mediasupervision.de \
--to=gregor@hoffleit.de \
--cc=sup-devel@rubyforge.org \
--cc=wmorgan-sup@masanjin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox