From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.223.78.141 with SMTP id l13cs50431fak; Sun, 13 Mar 2011 14:15:01 -0700 (PDT) Received: by 10.42.173.2 with SMTP id p2mr1832216icz.122.1300050900205; Sun, 13 Mar 2011 14:15:00 -0700 (PDT) Return-Path: Received: from rubyforge.org (rubyforge.org [205.234.109.19]) by mx.google.com with ESMTP id r10si17330264ict.102.2011.03.13.14.14.58; Sun, 13 Mar 2011 14:14:59 -0700 (PDT) Received-SPF: pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) client-ip=205.234.109.19; Authentication-Results: mx.google.com; spf=pass (google.com: domain of sup-devel-bounces@rubyforge.org designates 205.234.109.19 as permitted sender) smtp.mail=sup-devel-bounces@rubyforge.org Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 727E2185836B for ; Sun, 13 Mar 2011 17:14:58 -0400 (EDT) Received: from smtp.chost.de (setoy.chost.de [217.160.209.225]) by rubyforge.org (Postfix) with ESMTP id 0FC331858346 for ; Sun, 13 Mar 2011 16:21:15 -0400 (EDT) Received: (qmail 9971 invoked by uid 5015); 13 Mar 2011 20:21:24 -0000 Received: (nullmailer pid 24730 invoked by uid 123); Sun, 13 Mar 2011 20:21:14 -0000 Received: from twin.sascha.silbe.org (twin.sascha.silbe.org [192.168.1.2]) by flatty.sascha.silbe.org ([192.168.1.252]) with SMTP via TCP; 13 Mar 2011 20:21:14 -0000 Received: (nullmailer pid 12406 invoked by uid 8193); Sun, 13 Mar 2011 20:21:14 -0000 To: Damien Leone In-reply-to: <1300032642-sup-9716@mailer> References: <1300032642-sup-9716@mailer> Date: Sun, 13 Mar 2011 21:21:06 +0100 Message-Id: <1300045320-sup-8627@twin.sascha.silbe.org> User-Agent: Sup/git MIME-Version: 1.0 From: Sascha Silbe Cc: sup-devel Subject: Re: [sup-devel] [PATCHES] Add an account selector in edit-mode X-BeenThere: sup-devel@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: Sup developer discussion List-Id: Sup developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0715161217==" Sender: sup-devel-bounces@rubyforge.org Errors-To: sup-devel-bounces@rubyforge.org --===============0715161217== Content-Transfer-Encoding: 8bit Content-Type: multipart/signed; boundary="=-1300047674-210304-4025-2376-23-="; protocol="application/pgp-signature" --=-1300047674-210304-4025-2376-23-= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Excerpts from Damien Leone's message of Sun Mar 13 17:13:05 +0100 2011: > Sup guys, > = > Please see commit messages for detailed informations. > Attachment: 0001-reply-mode-improve-the-way-headers-are-handled.patch This one would possibly break my workflow. My From address is chosen in the before-edit hook based on the set of recipients. Since you only call before-edit once with headers_full as headers, whatever From address gets chosen for the initial reply mode will "stick". It also seems that something I wanted to do for some time was already possible with the old code, but isn't anymore with yours: Changing the contents of the To and CC fields for the selector. Even arbitrary headers= (Mail-Followup-To in my case) could be keyed on the selector. I now understand why before-edit was invoked multiple times. :) And the part where I need to avoid modifying the body on subsequent invocations looks like a bug in the original code: @bodies[k] should contain a _copy_ of body (currently all @bodies[k] contain a reference to the same instance, rendering the Hash useless). BTW, do you know about Hash.merge! ? Some parts of your code could have been simplified by using merge! instead of merge. Sascha -- = http://sascha.silbe.org/ http://www.infra-silbe.de/ --=-1300047674-210304-4025-2376-23-= Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1.0-git7d24ffa (GNU/Linux) iQEcBAEBCgAGBQJNfSc1AAoJELpz82VMF3DaX5MH/iEkEbvBRRcMFquftEjwcDvF fWIjROXV6yk9ZvbBjMRAlj6aRGCVo2Qx+Vcw4+hwd7jziUQn+MSSRUAIHeroSHln yOEkHXHp2CVULpiRXbA/rMb5MD0w+mdeXUA41s8gq+xcUGpwyVZHgqDShqlKTYvf yXUE+IdRonQ9GIPaA8wvUaUPTlRtBpmjKxQnDuucp6s1xc1b2S3UeSdikcP+qdbk 3/0lCuz5UK2IqyP2/h5KblBn0GY6Z9rC3LDqkIhDFbIvOkC6+frRBiUGMUMlU2Wp /qVp2zhhmu78GulaDB09gD4p+WF2U/LEhqHWvkwp+Q4k3Y9B5TM/YByHaa0TgAw= =RV9S -----END PGP SIGNATURE----- --=-1300047674-210304-4025-2376-23-=-- --===============0715161217== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Sup-devel mailing list Sup-devel@rubyforge.org http://rubyforge.org/mailman/listinfo/sup-devel --===============0715161217==--