From: Sascha Silbe <sascha-ml-reply-to-2011-2@silbe.org>
To: Damien Leone <damien.leone@fensalir.fr>
Cc: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] [PATCHES] Add an account selector in edit-mode
Date: Sun, 13 Mar 2011 21:21:06 +0100 [thread overview]
Message-ID: <1300045320-sup-8627@twin.sascha.silbe.org> (raw)
In-Reply-To: <1300032642-sup-9716@mailer>
[-- Attachment #1.1: Type: text/plain, Size: 1307 bytes --]
Excerpts from Damien Leone's message of Sun Mar 13 17:13:05 +0100 2011:
> Sup guys,
>
> Please see commit messages for detailed informations.
> Attachment: 0001-reply-mode-improve-the-way-headers-are-handled.patch
This one would possibly break my workflow. My From address is chosen in
the before-edit hook based on the set of recipients. Since you only
call before-edit once with headers_full as headers, whatever From
address gets chosen for the initial reply mode will "stick".
It also seems that something I wanted to do for some time was already
possible with the old code, but isn't anymore with yours: Changing the
contents of the To and CC fields for the selector. Even arbitrary headers
(Mail-Followup-To in my case) could be keyed on the selector. I now
understand why before-edit was invoked multiple times. :)
And the part where I need to avoid modifying the body on subsequent
invocations looks like a bug in the original code: @bodies[k] should
contain a _copy_ of body (currently all @bodies[k] contain a reference
to the same instance, rendering the Hash useless).
BTW, do you know about Hash.merge! ? Some parts of your code could have
been simplified by using merge! instead of merge.
Sascha
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 500 bytes --]
[-- Attachment #2: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
next prev parent reply other threads:[~2011-03-13 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 16:13 Damien Leone
2011-03-13 20:21 ` Sascha Silbe [this message]
2011-05-30 17:23 ` Hamish
2011-06-19 21:48 ` Hamish
2011-06-20 8:08 ` Damien Leone
2011-06-20 13:47 ` Sascha Silbe
2011-06-20 21:38 ` Hamish Downer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300045320-sup-8627@twin.sascha.silbe.org \
--to=sascha-ml-reply-to-2011-2@silbe.org \
--cc=damien.leone@fensalir.fr \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox