From: Gaute Hope <eg@gaute.vetsj.com>
To: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] new branch: keybindings
Date: Tue, 08 Feb 2011 09:01:44 +0100 [thread overview]
Message-ID: <1297152028-sup-5512@qwerzila> (raw)
In-Reply-To: <1296187729-sup-7405@zyrg.net>
Excerpts from Rich Lane's message of 2011-01-28 05:26:38 +0100:
> This branch makes the keybindings hook more useful. It moves the global
> keymap into a new GlobalMode that all others inherit from. This lets
> you write the same code to make a global keybinding as for a
> mode-specific one:
>
> class Redwood::GlobalMode
> keymap.add! :list_starred, "List all starred threads", "s"
>
> def list_starred
> SearchResultsMode.spawn_from_query "is:starred"
> end
> end
>
> I got rid of the "modes" local since I think it's better to just reopen
> the class with normal Ruby syntax. The keybindings hook is now exactly
> like the startup hook but with the O-k keybinding to reload it.
>
> This branch also makes it easier to write keybindings by catching and
> displaying exceptions from any keybinding, including builtin Sup ones.
> Masking Sup bugs isn't the goal (there's still a backtrace and bug
> report instructions) but the user experience is much better than losing
> a half-composed email.
>
> I've added some of my own keybindings (not using GlobalMode yet) to the
> wiki: http://sup.rubyforge.org/wiki/wiki.pl?CustomizingKeys
Could it be that this broke continue buffer search key 'n' ?
lib/sup/buffer.rb:171
This doesn't work for me anymore, could anyone confirm that?
Best regards,
Gaute Hope
next prev parent reply other threads:[~2011-02-08 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 4:26 Rich Lane
2011-02-08 8:01 ` Gaute Hope [this message]
2011-02-08 8:07 ` Gaute Hope
2011-02-13 18:05 ` Rich Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297152028-sup-5512@qwerzila \
--to=eg@gaute.vetsj.com \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox