From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: sup-devel <sup-devel@rubyforge.org>
Subject: Re: [sup-devel] sup dies when gpgme not present
Date: Thu, 27 Jan 2011 10:26:36 -0300 [thread overview]
Message-ID: <1296134724-sup-6117@alvh.no-ip.org> (raw)
In-Reply-To: <AANLkTi=52GtjhbzqvtMESP4Yn=npir_6x63pNp6sX=SL@mail.gmail.com>
Excerpts from Hamish D's message of jue ene 27 09:02:51 -0300 2011:
> > When the gpgme gem is not installed, this patch makes sup die on start
> > with:
> >
> > --- NameError from thread: main
> > uninitialized constant Redwood::CryptoManager::GPGME
> > /home/alvherre/Code/sup-mail/lib/sup/crypto.rb:49:in `initialize'
> > ...
>
> The code around that line is:
>
> # test if the gpgme gem is available
> @gpgme_present =
> begin
> begin
> GPGME.check_version({:protocol => GPGME::PROTOCOL_OpenPGP})
> <-- line 49
> true
> rescue GPGME::Error
> false
> end
> rescue NameError
> false
> end
>
> So we should rescue the NameError. Could you check whether the code
> for your sup looks like that?
It doesn't. The code I had failing was:
45 # test if the gpgme gem is available
46 @gpgme_present = true
47 begin
48 GPGME.check_version({:protocol => GPGME::PROTOCOL_OpenPGP})
49 rescue NameError, GPGME::Error
50 @gpgme_present = false
51 return
52 end
> Could you also temporarily remove the gpgme gem, update to the latest
> from master and see if you still get the same problem?
I have just updated to master and now the code looks like the snippet
you pasted. This was fixed in:
commit 02fbc3c8bb5e82a3ea67c2dd239bc3ccca36049e
Author: William Morgan <william@twitter.com>
Date: Wed Jan 19 15:47:28 2011 -0800
fix gpgme check
It works as is in 1.9, but in 1.8 it was throwing an exception for even
referencing GPGME::Error if gpgme wasn't installed.
I tried uninstalling gpgme and now it starts without dying.
--
Álvaro Herrera -- Se vende casa en Ñuñoa: www.portalinmobiliario.com/993147
_______________________________________________
Sup-devel mailing list
Sup-devel@rubyforge.org
http://rubyforge.org/mailman/listinfo/sup-devel
prev parent reply other threads:[~2011-01-27 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 12:02 Hamish D
2011-01-27 13:26 ` Alvaro Herrera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296134724-sup-6117@alvh.no-ip.org \
--to=alvherre@alvh.no-ip.org \
--cc=sup-devel@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox